Bug 74683 - Don't call Document::body() twice in the same function.
Summary: Don't call Document::body() twice in the same function.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-15 21:10 PST by Andreas Kling
Modified: 2011-12-16 00:51 PST (History)
1 user (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2011-12-15 21:10 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Patch (1.62 KB, patch)
2011-12-15 21:14 PST, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-12-15 21:10:14 PST 
Document::body() is O(n) and Document::updateLayoutIgnorePendingStylesheets() may call it twice for no good reason. We can't have this!
Comment 1 Andreas Kling 2011-12-15 21:10:56 PST 
Created attachment 119555 [details]
Patch
Comment 2 Andreas Kling 2011-12-15 21:14:30 PST 
Created attachment 119556 [details]
Patch
Comment 3 WebKit Review Bot 2011-12-16 00:51:35 PST 
Comment on attachment 119556 [details]
Patch

Clearing flags on attachment: 119556

Committed r103043: <http://trac.webkit.org/changeset/103043>
Comment 4 WebKit Review Bot 2011-12-16 00:51:41 PST 
All reviewed patches have been landed.  Closing bug.