To improve memory use and performance when .elements is used more than once.
Created attachment 120778 [details] Patch
Comment on attachment 120778 [details] Patch Actually, we can do slightly better.
Created attachment 120782 [details] Patch Same patch + get rid of the per-form CollectionCache. We don't need that anymore since there's only one HTMLFormCollection per form.
Created attachment 120811 [details] Patch
Comment on attachment 120811 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=120811&action=review > Source/WebCore/html/HTMLCollection.cpp:58 > + if (m_baseIsRetained) > + m_base->ref(); I think you need to deref m_base in the destructor.
(In reply to comment #5) > (From update of attachment 120811 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=120811&action=review > > > Source/WebCore/html/HTMLCollection.cpp:58 > > + if (m_baseIsRetained) > > + m_base->ref(); > > I think you need to deref m_base in the destructor. We already do! :)
Comment on attachment 120811 [details] Patch Clearing flags on attachment: 120811 Committed r103848: <http://trac.webkit.org/changeset/103848>
All reviewed patches have been landed. Closing bug.