SSIA
Created attachment 122663 [details] Patch
Comment on attachment 122663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=122663&action=review r=me, though this patch could be even more red > Source/WebCore/css/CSSStyleSelector.cpp:1070 > +static inline bool mappedAttributesEquivalent(NamedNodeMap* a, NamedNodeMap* b) > +{ > + ASSERT(a->mappedAttributeCount() == b->mappedAttributeCount()); Considering that canShareStyleWithElement seems to be only client for the mappedAttributeCount(), I wonder if it should be eliminated completely and done implicitly by this function. We don't even care about the actual count, just that they are equivalent.
Comment on attachment 122663 [details] Patch Clearing flags on attachment: 122663 Committed r105084: <http://trac.webkit.org/changeset/105084>
All reviewed patches have been landed. Closing bug.
Committed r105089: <http://trac.webkit.org/changeset/105089>
Reopen, because it broke dozens of tests on all platform: chromium: http://build.webkit.org/results/Chromium%20Win%20Release%20%28Tests%29/r105085%20%2822886%29/results.html GTK: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r105091%20%2816354%29/results.html Qt: http://build.webkit.org/results/Qt%20Linux%20Release/r105089%20%2842162%29/results.html Could you guys fix it?
(In reply to comment #6) > Reopen, because it broke dozens of tests on all platform: > chromium: http://build.webkit.org/results/Chromium%20Win%20Release%20%28Tests%29/r105085%20%2822886%29/results.html > GTK: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release/r105091%20%2816354%29/results.html > Qt: http://build.webkit.org/results/Qt%20Linux%20Release/r105089%20%2842162%29/results.html > > Could you guys fix it? Seems like a reasonable suggestion.
Committed r105095: <http://trac.webkit.org/changeset/105095>
(In reply to comment #8) > Committed r105095: <http://trac.webkit.org/changeset/105095> and http://trac.webkit.org/changeset/105089