Bug 77079 - REGRESSION (r104746): iframes load PDFs as media documents
Summary: REGRESSION (r104746): iframes load PDFs as media documents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Nobody
URL: http://www.cs.tut.fi/~jkorpela/html/i...
Keywords: InRadar, Regression
Depends on:
Blocks:
 
Reported: 2012-01-26 01:37 PST by mitz
Modified: 2012-02-09 09:31 PST (History)
5 users (show)

See Also:


Attachments
Patch to revert r104746. (4.64 KB, patch)
2012-02-08 18:22 PST, Mark Rowe (bdash)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2012-01-26 01:37:02 PST
To reproduce: navigate to the URL. Click inside a PDF and choose File > Print.

Result: The iframes start out with a black background and movie playback controls, then change to PDF views. When printing, the print preview shows only the visible portion of the PDF, instead of the entire document.
Comment 1 Radar WebKit Bug Importer 2012-01-26 01:38:01 PST
<rdar://problem/10757933>
Comment 2 Alexey Proskuryakov 2012-01-27 14:21:27 PST
Adam, is this something you intend to look into?
Comment 3 Adam Treat 2012-01-31 08:02:02 PST
(In reply to comment #2)
> Adam, is this something you intend to look into?

Speaking to me?
Comment 4 Adam Treat 2012-01-31 08:06:34 PST
(In reply to comment #3)
> (In reply to comment #2)
> > Adam, is this something you intend to look into?
> 
> Speaking to me?

https://bugs.webkit.org/show_bug.cgi?id=76088

I don't see how, but can someone look and see if ^^ regressed it?
Comment 5 mitz 2012-01-31 08:21:08 PST
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Adam, is this something you intend to look into?
> > 
> > Speaking to me?
> 
> https://bugs.webkit.org/show_bug.cgi?id=76088
> 
> I don't see how, but can someone look and see if ^^ regressed it?

The title of this bug indicates the revision that caused it. If that's not clear, see bug 76088 comment #9.
Comment 6 Adam Treat 2012-01-31 09:06:53 PST
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > (In reply to comment #2)
> > > > Adam, is this something you intend to look into?
> > > 
> > > Speaking to me?
> > 
> > https://bugs.webkit.org/show_bug.cgi?id=76088
> > 
> > I don't see how, but can someone look and see if ^^ regressed it?
> 
> The title of this bug indicates the revision that caused it. If that's not clear, see bug 76088 comment #9.

Sorry Mitz, someone pointed this bug to me with no context, but it immediately struck a chord and I replied before reading the additional comment on 76088.  I will indeed have a look.
Comment 7 Mark Rowe (bdash) 2012-02-08 18:19:20 PST
Is there any progress on this? This is a major functionality regression that has been in the tree for almost a month now. Unless it's going to be addressed in the near future I think we should simply roll out the offending patch.
Comment 8 Mark Rowe (bdash) 2012-02-08 18:22:43 PST
Created attachment 126214 [details]
Patch to revert r104746.
Comment 9 Adam Treat 2012-02-09 08:58:23 PST
(In reply to comment #7)
> Is there any progress on this? This is a major functionality regression that has been in the tree for almost a month now. Unless it's going to be addressed in the near future I think we should simply roll out the offending patch.

I've looked and can't find the bug in the logic so revert is in order for now.  Sorry guys.  I'll continue to look.
Comment 10 Adam Treat 2012-02-09 09:00:48 PST
(In reply to comment #9)
> (In reply to comment #7)
> > Is there any progress on this? This is a major functionality regression that has been in the tree for almost a month now. Unless it's going to be addressed in the near future I think we should simply roll out the offending patch.
> 
> I've looked and can't find the bug in the logic so revert is in order for now.  Sorry guys.  I'll continue to look.

Probably be a lot easier to spot if I could build the Mac port to reproduce the regression.  I recently acquired a macbook pro so I'll work on that.
Comment 11 Alexey Proskuryakov 2012-02-09 09:13:59 PST
Comment on attachment 126214 [details]
Patch to revert r104746.

Thanks Adam!
Comment 12 WebKit Review Bot 2012-02-09 09:31:22 PST
Comment on attachment 126214 [details]
Patch to revert r104746.

Clearing flags on attachment: 126214

Committed r107256: <http://trac.webkit.org/changeset/107256>
Comment 13 WebKit Review Bot 2012-02-09 09:31:27 PST
All reviewed patches have been landed.  Closing bug.