When I tried to build with the file system api feature, I faced the issue like following. >make: *** No rule to make target `../../Source/WebCore/fileapi/WebKitFlags.idl', needed by `DerivedSources/WebCore/supplemental_dependency.tmp'. Stop.
Created attachment 127199 [details] Patch
Attachment 127199 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit']" exit_code: 2 Updating OpenSource git.webkit.org[0: 17.254.20.231]: errno=Connection refused fatal: unable to connect a socket (Connection refused) Died at Tools/Scripts/update-webkit line 162. If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 127294 [details] Patch
Comment on attachment 127294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127294&action=review Just few nits in the ChangeLog. The patch looks good but it'd be nice to have green style-bot bubble. > Source/WebCore/ChangeLog:9 > + AIK, bug58443 also dealt with it, but it looks like the submitted patch AIK ? > Source/WebCore/ChangeLog:10 > + is needed to update. To do that, I think I need to discuss with the original author. needs to be updated.
Created attachment 127388 [details] Patch
Comment on attachment 127294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=127294&action=review Thank you! :) >> Source/WebCore/ChangeLog:9 >> + AIK, bug58443 also dealt with it, but it looks like the submitted patch > > AIK ? As I Know... sorry :p >> Source/WebCore/ChangeLog:10 >> + is needed to update. To do that, I think I need to discuss with the original author. > > needs to be updated. Done.
Comment on attachment 127388 [details] Patch LGTM, will cq+ after GTK ews gets green!
Comment on attachment 127388 [details] Patch Clearing flags on attachment: 127388 Committed r107986: <http://trac.webkit.org/changeset/107986>
All reviewed patches have been landed. Closing bug.