Bug 81380 - clang warning unused variable when ENABLE(TEXT_CARET) is disabled
Summary: clang warning unused variable when ENABLE(TEXT_CARET) is disabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-16 11:49 PDT by Joseph Pecoraro
Modified: 2012-03-16 15:27 PDT (History)
2 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.65 KB, patch)
2012-03-16 11:51 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2012-03-16 11:49:39 PDT 
In FrameSelection.cpp

    LayoutRect oldAbsoluteCaretRepaintBounds = m_absoluteCaretRepaintBounds;

is only used inside of ENABLE(TEXT_CARET). So there is an unused variable warning
when that is disabled.
Comment 1 Joseph Pecoraro 2012-03-16 11:51:33 PDT 
Created attachment 132335 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Review Bot 2012-03-16 15:27:15 PDT 
Comment on attachment 132335 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 132335

Committed r111079: <http://trac.webkit.org/changeset/111079>
Comment 3 WebKit Review Bot 2012-03-16 15:27:19 PDT 
All reviewed patches have been landed.  Closing bug.