Bug 82513 - minidom configurations should be based on ToolExecutable.xcconfig
Summary: minidom configurations should be based on ToolExecutable.xcconfig
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-28 13:16 PDT by David Kilzer (:ddkilzer)
Modified: 2012-03-28 20:00 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.50 KB, patch)
2012-03-28 13:16 PDT, David Kilzer (:ddkilzer)
no flags Details | Formatted Diff | Diff
Patch (3.14 KB, patch)
2012-03-28 16:54 PDT, David Kilzer (:ddkilzer)
mrowe: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2012-03-28 13:16:51 PDT
Created attachment 134380 [details]
Patch

Reviewed by NOBODY (OOPS!).

* Configurations/ToolExecutable.xcconfig: Extract
JAVASCRIPTCORE_RESOURCES_DIR into its own variable. Define
INSTALL_PATH based on TARGET_NAME.
* JavaScriptCore.xcodeproj/project.pbxproj: Base minidom
configurations on ToolExecutable.xcconfig.  Remove redundant
PRODUCT_NAME and SKIP_INSTALL variables.
---
 3 files changed, 23 insertions(+), 9 deletions(-)
Comment 1 WebKit Review Bot 2012-03-28 13:19:12 PDT
Attachment 134380 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1
Source/JavaScriptCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 2 Mark Rowe (bdash) 2012-03-28 13:24:07 PDT
Comment on attachment 134380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=134380&action=review

> Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig:29
> +INSTALL_PATH = $(INSTALL_PATH_$(TARGET_NAME));
> +INSTALL_PATH_JSCLLIntOffsetsExtractor = $(JAVASCRIPTCORE_RESOURCES_DIR);
> +INSTALL_PATH_minidom = /usr/local/bin;
> +INSTALL_PATH_testapi = $(JAVASCRIPTCORE_RESOURCES_DIR);
> +INSTALL_PATH_testRegExp = $(JAVASCRIPTCORE_RESOURCES_DIR);

This seems unnecessary. There's no good reason for minidom to be put in /usr/local/bin when everything else is going in to JavaScriptCore.framework/Resources.
Comment 3 David Kilzer (:ddkilzer) 2012-03-28 16:54:27 PDT
Created attachment 134446 [details]
Patch
Comment 4 David Kilzer (:ddkilzer) 2012-03-28 16:56:59 PDT
(In reply to comment #2)
> (From update of attachment 134380 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=134380&action=review
> 
> > Source/JavaScriptCore/Configurations/ToolExecutable.xcconfig:29
> > +INSTALL_PATH = $(INSTALL_PATH_$(TARGET_NAME));
> > +INSTALL_PATH_JSCLLIntOffsetsExtractor = $(JAVASCRIPTCORE_RESOURCES_DIR);
> > +INSTALL_PATH_minidom = /usr/local/bin;
> > +INSTALL_PATH_testapi = $(JAVASCRIPTCORE_RESOURCES_DIR);
> > +INSTALL_PATH_testRegExp = $(JAVASCRIPTCORE_RESOURCES_DIR);
> 
> This seems unnecessary. There's no good reason for minidom to be put in /usr/local/bin when everything else is going in to JavaScriptCore.framework/Resources.

Fixed in second patch.  (I kept the semi-colon, though!)
Comment 5 David Kilzer (:ddkilzer) 2012-03-28 20:00:49 PDT
Committed r112496: <http://trac.webkit.org/changeset/112496>