Bug 82613 - String: Subscript operator shouldn't force conversion to 16-bit characters.
Summary: String: Subscript operator shouldn't force conversion to 16-bit characters.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-03-29 07:27 PDT by Andreas Kling
Modified: 2012-03-29 12:28 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (1.21 KB, patch)
2012-03-29 07:49 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-03-29 07:27:11 PDT 
Using the subscript operator ([]) on a WTF::String currently forces the string to convert itself to 16-bit if it's 8-bit internally.
If we avoid this, we can save quite a bit of memory for the cases where this is the only thing triggering the conversion.
Comment 1 Andreas Kling 2012-03-29 07:49:12 PDT 
Created attachment 134582 [details]
Proposed patch
Comment 2 WebKit Review Bot 2012-03-29 10:04:17 PDT 
Comment on attachment 134582 [details]
Proposed patch

Clearing flags on attachment: 134582

Committed r112543: <http://trac.webkit.org/changeset/112543>
Comment 3 WebKit Review Bot 2012-03-29 10:04:22 PDT 
All reviewed patches have been landed.  Closing bug.