Bug 83540 - REGRESSION(r113588): 15-30% perf. regression on CSS/CSSPropertySetterGetter
Summary: REGRESSION(r113588): 15-30% perf. regression on CSS/CSSPropertySetterGetter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on: 83426
Blocks:
  Show dependency tree / graph
 
Reported: 2012-04-09 19:39 PDT by Ryosuke Niwa
Modified: 2012-04-10 14:57 PDT (History)
8 users (show)

See Also:

Attachments
Proposed patch (7.81 KB, patch)
2012-04-10 12:10 PDT, Andreas Kling 		koivisto: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Simpler patch (3.55 KB, patch)
2012-04-10 14:36 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Andreas Kling 2012-04-10 00:11:12 PDT 
Taking for tomorrow. We're triggering CSSOM clone instantiation from named CSS property getters in the bindings layer.
Comment 2 Andreas Kling 2012-04-10 12:10:36 PDT 
Created attachment 136502 [details]
Proposed patch
Comment 3 Antti Koivisto 2012-04-10 12:13:37 PDT 
Comment on attachment 136502 [details]
Proposed patch

r=me
Comment 4 Ryosuke Niwa 2012-04-10 12:16:29 PDT 
Comment on attachment 136502 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=136502&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:2689
> +PassRefPtr<CSSValue> CSSComputedStyleDeclaration::getUnsafePropertyCSSValueInternal(CSSPropertyID propertyID)

Can we reflect the idea that this CSSValue can't be exposed to the Web?
e.g. getPropertyCSSValueInternalWithoutCSSOMWrapper?
Comment 5 Antti Koivisto 2012-04-10 12:19:28 PDT 
We should eliminate getPropertyCSSValueInternal entirely. The only clients are in the editing code and that can just access the internal values.
Comment 6 Build Bot 2012-04-10 12:39:59 PDT 
Comment on attachment 136502 [details]
Proposed patch

Attachment 136502 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/12385221
Comment 7 Andreas Kling 2012-04-10 14:36:57 PDT 
Created attachment 136543 [details]
Simpler patch

Change the behavior of getPropertyCSSValueInternal() instead, yielding a much simpler patch.
Comment 8 Andreas Kling 2012-04-10 14:57:57 PDT 
Committed r113774: <http://trac.webkit.org/changeset/113774>