Bug 83988 - Remove contextStyleSheet argument from CSSValuePool::createFontFaceValue()
Summary: Remove contextStyleSheet argument from CSSValuePool::createFontFaceValue()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-04-14 15:33 PDT by Antti Koivisto
Modified: 2012-04-16 17:28 PDT (History)
4 users (show)

See Also:

Attachments
Pretty much a patch (5.44 KB, patch)
2012-04-16 16:01 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2012-04-14 15:33:39 PDT 
CSSValuePool::createFontFaceValue() takes context stylesheet as argument. This was ok when the pool was per-document but with global pool it can lead to font faces with relative URLs getting wrong base URL.
Comment 1 Antti Koivisto 2012-04-14 15:34:38 PDT 
This was added in http://trac.webkit.org/changeset/108451
Comment 2 Andreas Kling 2012-04-16 15:44:54 PDT 
There's no real bug here (yet) since CSSValuePool::createFontFaceValue() never ends up parsing a URL value. However we should still remove the contextStyleSheet argument as we can get away without it.
Comment 3 Antti Koivisto 2012-04-16 15:47:46 PDT 
Retitled
Comment 4 Andreas Kling 2012-04-16 15:59:25 PDT 
(In reply to comment #3)
> Retitled

I was trying to save you some face bro. Now everyone knows your assessment was partially incorrect :(
Comment 5 Andreas Kling 2012-04-16 16:01:26 PDT 
Created attachment 137422 [details]
Pretty much a patch
Comment 6 WebKit Review Bot 2012-04-16 17:28:27 PDT 
Comment on attachment 137422 [details]
Pretty much a patch

Clearing flags on attachment: 137422

Committed r114325: <http://trac.webkit.org/changeset/114325>
Comment 7 WebKit Review Bot 2012-04-16 17:28:32 PDT 
All reviewed patches have been landed.  Closing bug.