Bug 84871 - Add new ENABLE_LINK_PRERENDER define to control the Prerendering API
Summary: Add new ENABLE_LINK_PRERENDER define to control the Prerendering API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Peters
URL:
Keywords:
Depends on:
Blocks: 85005
  Show dependency tree / graph
 
Reported: 2012-04-25 09:52 PDT by Gavin Peters
Modified: 2012-04-27 09:37 PDT (History)
3 users (show)

See Also:

Attachments
Patch (30.63 KB, patch)
2012-04-25 09:57 PDT, Gavin Peters 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Peters 2012-04-25 09:52:00 PDT 
Add new ENABLE_LINK_PRERENDER define to control the Prerendering API
Comment 1 Gavin Peters 2012-04-25 09:57:50 PDT 
Created attachment 138829 [details]
Patch
Comment 2 Gavin Peters 2012-04-25 10:00:57 PDT 
Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering API separates it from prefetching.  Having separate include guards lets ports enable prefetching, a relatively easy change, without needing to build the infrastructure for prerendering, which is considerably more complicated.

This was carved out of the architecture review at https://bugs.webkit.org/show_bug.cgi?id=82478 , and got the LGTM from Adam in GitHub at https://github.com/gavinp/git.webkit.org/commit/fa83ece77731e42e280aaa3dd1ad594443666220
Comment 3 Gavin Peters 2012-04-25 10:01:20 PDT 
Comment on attachment 138829 [details]
Patch

I'll wait for EWS, and probably a ping from Mark Rowe before landing this.
Comment 4 WebKit Review Bot 2012-04-27 09:37:51 PDT 
Comment on attachment 138829 [details]
Patch

Clearing flags on attachment: 138829

Committed r115443: <http://trac.webkit.org/changeset/115443>
Comment 5 WebKit Review Bot 2012-04-27 09:37:56 PDT 
All reviewed patches have been landed.  Closing bug.