Bug 85315 - IndexedDB: Remove legacy enum-based constants from IDL
Summary: IndexedDB: Remove legacy enum-based constants from IDL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Grogan
URL:
Keywords: WebExposed
Depends on: 84894
Blocks:
  Show dependency tree / graph
 
Reported: 2012-05-01 14:59 PDT by Alec Flett
Modified: 2012-11-20 13:11 PST (History)
6 users (show)

See Also:

Attachments
Patch (30.54 KB, patch)
2012-11-19 18:36 PST, David Grogan 		no flags Details | Formatted Diff | Diff
Patch for landing (30.74 KB, patch)
2012-11-20 12:17 PST, David Grogan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alec Flett 2012-05-01 14:59:05 PDT 
After a few months/releases, we should remove the following constants from their respective IDL - there are constant strings that are now the standard:

IDBCursor.PREV
IDBCuroor.PREV_NO_DUPLICATE
IDBCursor.NEXT
IDBCursor.NEXT_NO_DUPLICATE
IDBTransaction.READ_ONLY
IDBTransaction.READ_WRITE

Strawman date: 12-Aug-2012
Comment 1 David Grogan 2012-11-19 18:36:27 PST 
Created attachment 175109 [details]
Patch
Comment 2 David Grogan 2012-11-19 18:37:16 PST 
Alec, Josh, could you take a look at this?
Comment 3 Alec Flett 2012-11-19 21:17:19 PST 
Comment on attachment 175109 [details]
Patch

LGTM.. good riddens!
Comment 4 Adam Barth 2012-11-19 23:43:01 PST 
Comment on attachment 175109 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=175109&action=review

> Source/WebCore/ChangeLog:8
> +
> +        Tests - legacy-constants.html

It would be good to add some explanation to the ChangeLog.  For example, you could say that these were removed from the final spec and that Firefox doesn't support them.
Comment 5 David Grogan 2012-11-20 12:17:38 PST 
Created attachment 175262 [details]
Patch for landing
Comment 6 David Grogan 2012-11-20 12:19:55 PST 
(In reply to comment #4)
> (From update of attachment 175109 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=175109&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +
> > +        Tests - legacy-constants.html
> 
> It would be good to add some explanation to the ChangeLog.  For example, you could say that these were removed from the final spec and that Firefox doesn't support them.

SG, added. Firefox supports these constants (as of 18.0a2) but I suppose one of us has to remove them first.
Comment 7 WebKit Review Bot 2012-11-20 13:11:04 PST 
Comment on attachment 175262 [details]
Patch for landing

Clearing flags on attachment: 175262

Committed r135308: <http://trac.webkit.org/changeset/135308>
Comment 8 WebKit Review Bot 2012-11-20 13:11:08 PST 
All reviewed patches have been landed.  Closing bug.