Bug 86126 - Remove empty ElementAttributeData destructor.
Summary: Remove empty ElementAttributeData destructor.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-10 12:24 PDT by Andreas Kling
Modified: 2012-05-13 17:38 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.60 KB, patch)
2012-05-10 12:24 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-05-10 12:24:10 PDT 
True story.
Comment 1 Andreas Kling 2012-05-10 12:24:53 PDT 
Created attachment 141224 [details]
Patch
Comment 2 Tom Zakrajsek 2012-05-10 12:39:04 PDT 
Where's the test?  ;)
Comment 3 WebKit Review Bot 2012-05-10 13:42:26 PDT 
Comment on attachment 141224 [details]
Patch

Clearing flags on attachment: 141224

Committed r116682: <http://trac.webkit.org/changeset/116682>
Comment 4 WebKit Review Bot 2012-05-10 13:42:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2012-05-13 16:29:50 PDT 
Did this have any performance effect? Does this mean that the destructor is now inlined?
Comment 6 Andreas Kling 2012-05-13 17:38:19 PDT 
(In reply to comment #5)
> Did this have any performance effect? Does this mean that the destructor is now inlined?

The destructor is now inlined indeed. Nothing exciting on perf bots though.