Bug 87076 - DOM Attr objects pointing to "style" attribute should force reification when read.
Summary: DOM Attr objects pointing to "style" attribute should force reification when ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-21 19:58 PDT by Andreas Kling
Modified: 2012-05-22 05:05 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.63 KB, patch)
2012-05-22 00:30 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-05-21 19:58:34 PDT 
DOM Attr needs to respect the lazy serialization strategy of the style attribute.
Comment 1 Andreas Kling 2012-05-22 00:30:23 PDT 
Created attachment 143212 [details]
Patch
Comment 2 Antti Koivisto 2012-05-22 01:14:19 PDT 
Comment on attachment 143212 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=143212&action=review

r=me

> Source/WebCore/dom/Attr.cpp:206
>      if (m_element)
> -        return m_element->getAttributeItem(qualifiedName())->value();
> +        return m_element->getAttribute(qualifiedName());

Could use a comment.
Comment 3 Andreas Kling 2012-05-22 05:05:44 PDT 
Comment on attachment 143212 [details]
Patch

Clearing flags on attachment: 143212

Committed r117956: <http://trac.webkit.org/changeset/117956>
Comment 4 Andreas Kling 2012-05-22 05:05:52 PDT 
All reviewed patches have been landed.  Closing bug.