Bug 87876 - Have StylePropertySet constructor take array/length instead of vector.
Summary: Have StylePropertySet constructor take array/length instead of vector.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-05-30 11:03 PDT by Andreas Kling
Modified: 2012-05-31 06:39 PDT (History)
5 users (show)

See Also:

Attachments
A patch, I guess. (9.04 KB, patch)
2012-05-30 11:11 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-05-30 11:03:06 PDT 
The constructor has to copy anyway, so there's no need to force call sites to use the no-longer-used StylePropertyVector for storage.
Comment 1 Andreas Kling 2012-05-30 11:11:57 PDT 
Created attachment 144873 [details]
A patch, I guess.
Comment 2 Antti Koivisto 2012-05-30 12:15:13 PDT 
Comment on attachment 144873 [details]
A patch, I guess.

View in context: https://bugs.webkit.org/attachment.cgi?id=144873&action=review

> Source/WebCore/css/StylePropertySet.h:50
> +    static PassRefPtr<StylePropertySet> create(const CSSProperty* properties, unsigned count)

This could be named createMutable
Comment 3 Andreas Kling 2012-05-31 06:39:13 PDT 
Committed r119097: <http://trac.webkit.org/changeset/119097>