Bug 89659 - REGRESSION(r120329): Intermittent WebProcess shutdowns due to out-of-line DidReceiveEvent messages.
Summary: REGRESSION(r120329): Intermittent WebProcess shutdowns due to out-of-line Did...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2012-06-21 07:00 PDT by Andreas Kling
Modified: 2012-06-24 22:15 PDT (History)
6 users (show)

See Also:


Attachments
Sad but effective patch (6.90 KB, patch)
2012-06-21 07:02 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-06-21 07:00:20 PDT
<rdar://problem/11686974>
Comment 1 Andreas Kling 2012-06-21 07:02:51 PDT
Created attachment 148791 [details]
Sad but effective patch
Comment 2 Sam Weinig 2012-06-21 16:38:45 PDT
Comment on attachment 148791 [details]
Sad but effective patch

It does not seem acceptable to add a synchronous message here.

r-.
Comment 3 Andreas Kling 2012-06-21 19:06:05 PDT
(In reply to comment #2)
> (From update of attachment 148791 [details])
> It does not seem acceptable to add a synchronous message here.
> 
> r-.

I suppose it's worth noting that every other WebProcess->UIProcess message apart from DidReceiveEvent involved in keyboard input is already synchronous.

Not sure how to solve this one cleanly. May have to rethink the r120329 instead.
Comment 4 Sam Weinig 2012-06-22 16:22:24 PDT
Comment on attachment 148791 [details]
Sad but effective patch

Since it is unclear how to make this work easily without AppKit changes, lets take this for now.  Please file a follow up to remove this message.
Comment 5 Sam Weinig 2012-06-22 16:24:06 PDT
Also, please try to construct a test in TestWebKitAPI as well (this does not need to gate checkin).
Comment 6 WebKit Review Bot 2012-06-24 01:15:26 PDT
Comment on attachment 148791 [details]
Sad but effective patch

Clearing flags on attachment: 148791

Committed r121113: <http://trac.webkit.org/changeset/121113>
Comment 7 WebKit Review Bot 2012-06-24 01:15:37 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Simon Fraser (smfr) 2012-06-24 15:39:24 PDT
Looks like this is causing a bunch of new assertions on the bots:
http://build.webkit.org/results/Apple%20Lion%20Debug%20WK2%20(Tests)/r121121%20(535)/results.html
Comment 9 Andreas Kling 2012-06-24 15:43:31 PDT
(In reply to comment #8)
> Looks like this is causing a bunch of new assertions on the bots:
> http://build.webkit.org/results/Apple%20Lion%20Debug%20WK2%20(Tests)/r121121%20(535)/results.html

Roger. WebPageProxy::handleKeyboardEvent() should be calling didReceiveKeyEvent() rather than didReceiveEvent(). Fixing in a minute(tm).
Comment 10 Andreas Kling 2012-06-24 22:15:27 PDT
Committed r121138: <http://trac.webkit.org/changeset/121138>