Bug 91022 - WebFullScreenController and WKFullScreenWindowController shouldn't add unprefixed methods to AppKit classes
Summary: WebFullScreenController and WKFullScreenWindowController shouldn't add unpref...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-11 15:02 PDT by Mark Rowe (bdash)
Modified: 2012-07-11 19:08 PDT (History)
0 users

See Also:

Attachments
Patch v1 (6.89 KB, patch)
2012-07-11 15:08 PDT, Mark Rowe (bdash) 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2012-07-11 15:02:31 PDT 
WebFullScreenController and WKFullScreenWindowController both add a method named convertRectToScreen: on to NSWindow via a category when building for 10.6 and earlier. This causes problems when building for 10.6 against a newer SDK as NSWindow already has a method of that name. It's also unhygienic as it could interfere with a client application that provides methods of the same name.
Comment 1 Mark Rowe (bdash) 2012-07-11 15:08:07 PDT 
Created attachment 151794 [details]
Patch v1
Comment 2 Mark Rowe (bdash) 2012-07-11 19:08:32 PDT 
Landed in r122403.