Bug 92032 - Report the extra memory used by immutable StylePropertySet objects.
Summary: Report the extra memory used by immutable StylePropertySet objects.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-23 14:49 PDT by Andreas Kling
Modified: 2012-07-23 15:57 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.28 KB, patch)
2012-07-23 14:55 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-07-23 14:49:09 PDT 
If StylePropertySet::m_isMutable is false, the object is actually larger than sizeof(StylePropertySet) - it's sizeof(StylePropertySet) + m_arraySize * sizeof(CSSProperty).
We should include this in reportMemoryUsage() to get more accurate numbers in the Inspector.
Comment 1 Andreas Kling 2012-07-23 14:55:26 PDT 
Created attachment 153869 [details]
Patch
Comment 2 Andreas Kling 2012-07-23 15:56:56 PDT 
Comment on attachment 153869 [details]
Patch

Clearing flags on attachment: 153869

Committed r123396: <http://trac.webkit.org/changeset/123396>
Comment 3 Andreas Kling 2012-07-23 15:57:02 PDT 
All reviewed patches have been landed.  Closing bug.