Bug 92524 - Hit testing near a column break can return a result from an adjacent column when there is leading
Summary: Hit testing near a column break can return a result from an adjacent column w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-07-27 11:38 PDT by mitz
Modified: 2012-07-27 13:00 PDT (History)
2 users (show)

See Also:

Attachments
Add RootInlineBox::isFirstAfterPageBreak() and use it instead of relying on the presence of a pagination strut (7.77 KB, patch)
2012-07-27 11:49 PDT, mitz 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2012-07-27 11:38:09 PDT 
Hit testing near a column break can return a result from an adjacent column when there is leading
Comment 1 mitz 2012-07-27 11:49:19 PDT 
Created attachment 155001 [details]
Add RootInlineBox::isFirstAfterPageBreak() and use it instead of relying on the presence of a pagination strut
Comment 2 mitz 2012-07-27 12:26:07 PDT 
Fixed in <http://trac.webkit.org/r123904>.
Comment 3 Darin Adler 2012-07-27 13:00:35 PDT 
Comment on attachment 155001 [details]
Add RootInlineBox::isFirstAfterPageBreak() and use it instead of relying on the presence of a pagination strut

View in context: https://bugs.webkit.org/attachment.cgi?id=155001&action=review

> Source/WebCore/rendering/InlineFlowBox.h:325
> +    bool m_isFirstAfterPageBreak : 1;

To keep this small on Windows, you should declare it as unsigned even though the sensible type to use is bool.