Bug 97269 - Kerning never occurs between a space and the following glyph
Summary: Kerning never occurs between a space and the following glyph
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-20 16:05 PDT by mitz
Modified: 2014-12-03 19:04 PST (History)
3 users (show)

See Also:

Attachments
Maintain the advances of space characters (316.00 KB, patch)
2012-09-20 16:09 PDT, mitz 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2012-09-20 16:05:27 PDT 
Kerning never occurs between a space and the following glyph
Comment 1 mitz 2012-09-20 16:09:59 PDT 
Created attachment 165005 [details]
Maintain the advances of space characters
Comment 2 mitz 2012-09-20 16:19:28 PDT 
Fixed in <http://trac.webkit.org/r129176>.
Comment 4 mitz 2012-09-20 19:18:41 PDT 
(In reply to comment #3)
> This broke a test:
> http://build.webkit.org/results/Apple%20Lion%20Release%20WK1%20(Tests)/r129181%20(3827)/results.html

Thanks for noticing this. The original change included updated results for this test for current OS X, but failed to update the Lion results. I have since updated them.
Comment 5 mitz 2012-09-24 10:49:12 PDT 
This changed led to an inconsistency between the measurements in line breaking and the ones in RenderText::computePreferredLogicalWidths, which measures spaces separately from their surroundings. I am going to revert it for now.
Comment 6 mitz 2012-09-24 11:17:52 PDT 
Reverted in <http://trac.webkit.org/r129389>.
Comment 7 Eric Seidel (no email) 2013-03-01 10:39:37 PST 
Comment on attachment 165005 [details]
Maintain the advances of space characters

Cleared Tim Horton's review+ from obsolete attachment 165005 [details] so that this bug does not appear in http://webkit.org/pending-commit.