Someone did it right with the 'm_needsFocusAppearanceUpdateSoonAfterAttach' flag, we just need to move the rest of the (3) flags from ElementRareData to NodeRareData and we'll save 8 bytes per raredata.
Created attachment 166800 [details] Patch
Comment on attachment 166800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166800&action=review r=me > Source/WebCore/ChangeLog:9 > + Move all bool flags from ElementRareData to the bitfield in its base class NodeRareData. > + This shrinks ElementRareData by 8 bytes (on 64-bit.) Also removed some double raredata hash lookups. Would be nice to tell why this is worth doing.
Created attachment 166867 [details] Potch for londong
Comment on attachment 166867 [details] Potch for londong Clearing flags on attachment: 166867 Committed r130278: <http://trac.webkit.org/changeset/130278>
All reviewed patches have been landed. Closing bug.
Comment on attachment 166800 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166800&action=review >> Source/WebCore/ChangeLog:9 >> + This shrinks ElementRareData by 8 bytes (on 64-bit.) Also removed some double raredata hash lookups. > > Would be nice to tell why this is worth doing. Do we want a rare data compile time size assertion so people notice when they bloat it?