Bug 98225 - Shrink ElementRareData by moving bool flags to NodeRareData.
Summary: Shrink ElementRareData by moving bool flags to NodeRareData.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-02 20:19 PDT by Andreas Kling
Modified: 2012-10-03 09:04 PDT (History)
2 users (show)

See Also:


Attachments
Patch (7.95 KB, patch)
2012-10-02 20:23 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff
Potch for londong (8.00 KB, patch)
2012-10-03 05:34 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-10-02 20:19:03 PDT
Someone did it right with the 'm_needsFocusAppearanceUpdateSoonAfterAttach' flag, we just need to move the rest of the (3) flags from ElementRareData to NodeRareData and we'll save 8 bytes per raredata.
Comment 1 Andreas Kling 2012-10-02 20:23:35 PDT
Created attachment 166800 [details]
Patch
Comment 2 Antti Koivisto 2012-10-02 20:30:07 PDT
Comment on attachment 166800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166800&action=review

r=me

> Source/WebCore/ChangeLog:9
> +        Move all bool flags from ElementRareData to the bitfield in its base class NodeRareData.
> +        This shrinks ElementRareData by 8 bytes (on 64-bit.) Also removed some double raredata hash lookups.

Would be nice to tell why this is worth doing.
Comment 3 Andreas Kling 2012-10-03 05:34:37 PDT
Created attachment 166867 [details]
Potch for londong
Comment 4 WebKit Review Bot 2012-10-03 05:55:14 PDT
Comment on attachment 166867 [details]
Potch for londong

Clearing flags on attachment: 166867

Committed r130278: <http://trac.webkit.org/changeset/130278>
Comment 5 WebKit Review Bot 2012-10-03 05:55:17 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2012-10-03 09:04:30 PDT
Comment on attachment 166800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166800&action=review

>> Source/WebCore/ChangeLog:9
>> +        This shrinks ElementRareData by 8 bytes (on 64-bit.) Also removed some double raredata hash lookups.
> 
> Would be nice to tell why this is worth doing.

Do we want a rare data compile time size assertion so people notice when they bloat it?