Bug 98987 - ElementAttributeData shouldn't be managing Element's callbacks.
Summary: ElementAttributeData shouldn't be managing Element's callbacks.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-10-10 20:57 PDT by Andreas Kling
Modified: 2012-10-11 15:51 PDT (History)
4 users (show)

See Also:

Attachments
poch (12.73 KB, patch)
2012-10-10 21:35 PDT, Andreas Kling 		andersca: review+
Details | Formatted Diff | Diff
Rebasereded (12.82 KB, patch)
2012-10-10 23:07 PDT, Andreas Kling 		webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
sigh (12.75 KB, patch)
2012-10-11 12:29 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
please merge? (12.70 KB, patch)
2012-10-11 14:06 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2012-10-10 20:57:02 PDT 
ElementAttributeData shouldn't be managing Element's callbacks.
Comment 1 Andreas Kling 2012-10-10 21:35:59 PDT 
Created attachment 168140 [details]
poch
Comment 2 Anders Carlsson 2012-10-10 21:37:21 PDT 
is gud poch!
Comment 3 Andreas Kling 2012-10-10 21:38:29 PDT 
(In reply to comment #2)
> is gud poch!

anders pls
Comment 4 Andreas Kling 2012-10-10 23:07:37 PDT 
Created attachment 168146 [details]
Rebasereded
Comment 5 WebKit Review Bot 2012-10-10 23:57:28 PDT 
Comment on attachment 168146 [details]
Rebasereded

Attachment 168146 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14250631

New failing tests:
dom/html/level1/core/hc_elementremoveattribute.html
dom/html/level1/core/hc_elementremoveattributenode.html
dom/xhtml/level1/core/hc_attrappendchild1.xhtml
dom/html/level1/core/hc_attrchildnodes2.html
dom/html/level1/core/hc_attrcreatetextnode2.html
dom/html/level1/core/hc_attrappendchild1.html
dom/html/level1/core/hc_attrappendchild3.html
dom/xhtml/level1/core/hc_attrappendchild5.xhtml
dom/html/level1/core/hc_attrinsertbefore1.html
dom/html/level1/core/hc_attrinsertbefore3.html
dom/html/level1/core/hc_attrinsertbefore2.html
dom/html/level1/core/hc_attrreplacechild1.html
dom/html/level1/core/hc_attrreplacechild2.html
dom/xhtml/level1/core/hc_attrcreatetextnode2.xhtml
dom/html/level1/core/hc_attrinsertbefore6.html
dom/html/level1/core/hc_attrappendchild5.html
dom/html/level1/core/hc_elementnormalize2.html
dom/html/level1/core/hc_attrsetvalue2.html
dom/html/level1/core/hc_attrinsertbefore4.html
dom/xhtml/level1/core/hc_attrchildnodes2.xhtml
dom/html/level1/core/hc_attrnormalize.html
dom/html/level1/core/hc_attrsetvalue1.html
accessibility/aria-hidden-updates-alldescendants.html
dom/xhtml/level1/core/hc_attrappendchild3.xhtml
dom/html/level1/core/hc_attrremovechild1.html
dom/xhtml/level1/core/hc_attrclonenode1.xhtml
canvas/philip/tests/size.attributes.removed.html
dom/html/level1/core/hc_namednodemapremovenameditem.html
dom/html/level1/core/hc_attrclonenode1.html
dom/html/level1/core/hc_attrcreatetextnode.html
Comment 6 Andreas Kling 2012-10-11 12:29:15 PDT 
Created attachment 168259 [details]
sigh
Comment 7 Andreas Kling 2012-10-11 14:06:27 PDT 
Created attachment 168274 [details]
please merge?
Comment 8 WebKit Review Bot 2012-10-11 15:51:34 PDT 
Comment on attachment 168274 [details]
please merge?

Clearing flags on attachment: 168274

Committed r131104: <http://trac.webkit.org/changeset/131104>
Comment 9 WebKit Review Bot 2012-10-11 15:51:38 PDT 
All reviewed patches have been landed.  Closing bug.