Bug 113779 - Web Inspector: [Mac/WK1] Provide way to disable docking for the Web Inspector
Summary: Web Inspector: [Mac/WK1] Provide way to disable docking for the Web Inspector
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-02 06:50 PDT by Timothy Hatcher
Modified: 2013-04-02 12:05 PDT (History)
4 users (show)

See Also:

Attachments
Proposed Change (8.22 KB, patch)
2013-04-02 06:55 PDT, Timothy Hatcher 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2013-04-02 06:50:58 PDT 
Provide a way to disable the attach button in the Web Inspector and always open in a window.

<rdar://problem/13446021>
Comment 1 Timothy Hatcher 2013-04-02 06:55:32 PDT 
Created attachment 196130 [details]
Proposed Change
Comment 2 Joseph Pecoraro 2013-04-02 11:24:00 PDT 
Comment on attachment 196130 [details]
Proposed Change

View in context: https://bugs.webkit.org/attachment.cgi?id=196130&action=review

> Source/WebKit/cf/ChangeLog:5
> +        The user default is "WebKit Web Inspector Setting - inspectorAttachDisabled".

This seems good for now. Ideally this could be set, per-WebInspector.

> Source/WebKit/cf/WebCoreSupport/WebInspectorClientCF.cpp:110
> +    storeSetting(inspectorAttachDisabledSetting, disabled ? "true" : "false");

These could be ASCIILiteral("true") and ASCIILiteral("false") (fast path String construction from literals).
Comment 3 WebKit Review Bot 2013-04-02 12:05:05 PDT 
Comment on attachment 196130 [details]
Proposed Change

Clearing flags on attachment: 196130

Committed r147482: <http://trac.webkit.org/changeset/147482>
Comment 4 WebKit Review Bot 2013-04-02 12:05:09 PDT 
All reviewed patches have been landed.  Closing bug.