Webkit exposes aria-expanded="undefined" as aria-expanded="false" (AXExpanded = NO) It should not expose this value unless the string value matches true or false. All other values (including "undefined", "foo", etc.) should not expose the AXExpanded property at all, b/c a NO value means "expandable but not expanded" whereas an undefined value means "not expandable." Test Cases: https://dvcs.w3.org/hg/pfwg/raw-file/default/ARIA/1.0/tests/test-files/roles-properties-supported-inherited/roles-properties-supported-inherited-tabpanel-aria-expanded-undefined.html https://dvcs.w3.org/hg/pfwg/raw-file/default/ARIA/1.0/tests/test-files/roles-properties-supported-inherited/roles-properties-supported-inherited-timer-aria-expanded-undefined.html https://dvcs.w3.org/hg/pfwg/raw-file/default/ARIA/1.0/tests/test-files/roles-properties-supported-inherited/roles-properties-supported-inherited-toolbar-aria-expanded-undefined.html https://dvcs.w3.org/hg/pfwg/raw-file/default/ARIA/1.0/tests/test-files/roles-properties-supported-inherited/roles-properties-supported-inherited-tooltip-aria-expanded-undefined.html https://dvcs.w3.org/hg/pfwg/raw-file/default/ARIA/1.0/tests/test-files/roles-properties-supported-inherited/roles-properties-supported-inherited-tree-aria-expanded-undefined.html https://dvcs.w3.org/hg/pfwg/raw-file/default/ARIA/1.0/tests/test-files/roles-properties-supported-inherited/roles-properties-supported-inherited-treegrid-aria-expanded-undefined.html
<rdar://problem/13569954>
*** Bug 115148 has been marked as a duplicate of this bug. ***
Created attachment 209278 [details] patch
Comment on attachment 209278 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=209278&action=review > Source/WebCore/accessibility/AccessibilityObject.cpp:1634 > + const AtomicString& expanded = getAttribute(aria_expandedAttr); Should be fastGetAttribute.
Comment on attachment 209278 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=209278&action=review >> Source/WebCore/accessibility/AccessibilityObject.cpp:1634 >> + const AtomicString& expanded = getAttribute(aria_expandedAttr); > > Should be fastGetAttribute. this is using the AXObject's getAttr method, which looks like it does call fastGetAttribute so we should be ok. thanks
Comment on attachment 209278 [details] patch Clearing flags on attachment: 209278 Committed r154496: <http://trac.webkit.org/changeset/154496>
All reviewed patches have been landed. Closing bug.