Bug 115968 - [Mac] The captions menu should not use a canned max-width and max-height
Summary: [Mac] The captions menu should not use a canned max-width and max-height
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-05-11 13:41 PDT by Antoine Quint
Modified: 2013-05-11 14:42 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.17 KB, patch)
2013-05-11 13:45 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2013-05-11 13:41:15 PDT 
Currently, the captions menu (::-webkit-media-controls-closed-captions-track-list) has "max-width" and "max-height" set to 250px. When the captions name are long, it may happen that the name of the caption is clipped even though there is plenty of space available to display the full title over the video. The max-width and max-height of the captions menu should be dependent on the available video real-estate.
Comment 1 Antoine Quint 2013-05-11 13:41:33 PDT 
<rdar://problem/13760800>
Comment 2 Antoine Quint 2013-05-11 13:45:51 PDT 
Created attachment 201470 [details]
Patch
Comment 3 WebKit Commit Bot 2013-05-11 14:42:03 PDT 
Comment on attachment 201470 [details]
Patch

Clearing flags on attachment: 201470

Committed r149942: <http://trac.webkit.org/changeset/149942>
Comment 4 WebKit Commit Bot 2013-05-11 14:42:05 PDT 
All reviewed patches have been landed.  Closing bug.