Web Inspector: AX: Add support for ARIA tablists/tabs to inspector tabs I count at least four sets of tabs: 2 in the main toolbar, 1 in the console toolbar, and 1 in the element Styles inspector.
<rdar://problem/14283943>
What is the definition of tab and tab list?
Those are ARIA roles. http://www.w3.org/WAI/PF/aria/complete#tab http://www.w3.org/WAI/PF/aria/complete#tablist
Styles Inspector tab fixed as part of the patch for bug 118105, so this one should just cover the main tabs, and any others that still aren't fixed.
Typo: Above reference should read …as part of the patch for bug 118104, not 118105.
Created attachment 208883 [details] patch
Comment on attachment 208883 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=208883&action=review r=me > Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js:33 > + Style: Remove this extra blank line. > Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js:64 > + if (this._role == "tab") Style: In Web Inspector we use strict equality `===` whenever possible. > Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js:69 > + if (this._role == "tab") === > Source/WebInspectorUI/UserInterface/Toolbar.js:38 > + this._leftSectionElement.setAttribute('role', 'tablist'); Style: In Web Inspector we use double quoted strings whenever possible. "role" / "tablist". > Source/WebInspectorUI/UserInterface/Toolbar.js:47 > + this._rightSectionElement.setAttribute('role', 'tablist'); "…"
(In reply to comment #7) > Style: In Web Inspector we use double quoted strings whenever possible. "role" / "tablist". Do you think this is worth updating the check-webkit-style script?
(In reply to comment #8) > Do you think this is worth updating the check-webkit-style script? bug 118105
(In reply to comment #8) > Do you think this is worth updating the check-webkit-style script? Oops. Bug 119901.
Created attachment 208932 [details] patch with review feedback
Comment on attachment 208932 [details] patch with review feedback Rejecting attachment 208932 [details] from commit-queue. james@cookiecrook.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
commit‑queue?
Comment on attachment 208932 [details] patch with review feedback Real review by Joe, but setting the flag to make it through commit bot
Comment on attachment 208932 [details] patch with review feedback Clearing flags on attachment: 208932 Committed r154196: <http://trac.webkit.org/changeset/154196>
All reviewed patches have been landed. Closing bug.