Bug 118105 - Web Inspector: AX: Add support for ARIA tablists/tabs to inspector tabs
Summary: Web Inspector: AX: Add support for ARIA tablists/tabs to inspector tabs
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: James Craig
URL:
Keywords: InRadar
Depends on: 118104
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-26 17:18 PDT by James Craig
Modified: 2013-08-16 11:42 PDT (History)
6 users (show)

See Also:


Attachments
patch (6.42 KB, patch)
2013-08-15 23:35 PDT, James Craig
joepeck: review+
Details | Formatted Diff | Diff
patch with review feedback (6.42 KB, patch)
2013-08-16 11:04 PDT, James Craig
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Craig 2013-06-26 17:18:17 PDT
Web Inspector: AX: Add support for ARIA tablists/tabs to inspector tabs

I count at least four sets of tabs: 2 in the main toolbar, 1 in the console toolbar, and 1 in the element Styles inspector.
Comment 1 Radar WebKit Bug Importer 2013-06-26 17:18:30 PDT
<rdar://problem/14283943>
Comment 2 Timothy Hatcher 2013-06-26 17:22:45 PDT
What is the definition of tab and tab list?
Comment 4 James Craig 2013-06-27 02:47:05 PDT
Styles Inspector tab fixed as part of the patch for bug 118105, so this one should just cover the main tabs, and any others that still aren't fixed.
Comment 5 James Craig 2013-06-27 02:48:50 PDT
Typo: Above reference should read …as part of the patch for bug 118104, not 118105.
Comment 6 James Craig 2013-08-15 23:35:40 PDT
Created attachment 208883 [details]
patch
Comment 7 Joseph Pecoraro 2013-08-16 10:30:08 PDT
Comment on attachment 208883 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208883&action=review

r=me

> Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js:33
> +

Style: Remove this extra blank line.

> Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js:64
> +            if (this._role == "tab")

Style: In Web Inspector we use strict equality `===` whenever possible.

> Source/WebInspectorUI/UserInterface/ActivateButtonNavigationItem.js:69
> +            if (this._role == "tab")

===

> Source/WebInspectorUI/UserInterface/Toolbar.js:38
> +    this._leftSectionElement.setAttribute('role', 'tablist');

Style: In Web Inspector we use double quoted strings whenever possible. "role" / "tablist".

> Source/WebInspectorUI/UserInterface/Toolbar.js:47
> +    this._rightSectionElement.setAttribute('role', 'tablist');

"…"
Comment 8 James Craig 2013-08-16 10:54:29 PDT
(In reply to comment #7)
> Style: In Web Inspector we use double quoted strings whenever possible. "role" / "tablist".

Do you think this is worth updating the check-webkit-style script?
Comment 9 James Craig 2013-08-16 10:58:19 PDT
(In reply to comment #8)
> Do you think this is worth updating the check-webkit-style script?

bug 118105
Comment 10 James Craig 2013-08-16 10:59:10 PDT
(In reply to comment #8)

> Do you think this is worth updating the check-webkit-style script?

Oops. Bug 119901.
Comment 11 James Craig 2013-08-16 11:04:20 PDT
Created attachment 208932 [details]
patch with review feedback
Comment 12 WebKit Commit Bot 2013-08-16 11:10:42 PDT
Comment on attachment 208932 [details]
patch with review feedback

Rejecting attachment 208932 [details] from commit-queue.

james@cookiecrook.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 13 James Craig 2013-08-16 11:12:56 PDT
commit‑queue?
Comment 14 chris fleizach 2013-08-16 11:13:23 PDT
Comment on attachment 208932 [details]
patch with review feedback

Real review by Joe, but setting the flag to make it through commit bot
Comment 15 WebKit Commit Bot 2013-08-16 11:42:20 PDT
Comment on attachment 208932 [details]
patch with review feedback

Clearing flags on attachment: 208932

Committed r154196: <http://trac.webkit.org/changeset/154196>
Comment 16 WebKit Commit Bot 2013-08-16 11:42:22 PDT
All reviewed patches have been landed.  Closing bug.