Bug 118171 - RenderLayer: Check SVG bit instead of element namespace in isTransparent().
Summary: RenderLayer: Check SVG bit instead of element namespace in isTransparent().
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-06-27 23:39 PDT by Andreas Kling
Modified: 2013-10-13 00:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.26 KB, patch)
2013-06-27 23:40 PDT, Andreas Kling 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-06-27 23:39:18 PDT 
RenderLayer::isTransparent() is checking for SVG elements by doing renderer()->node()->namespaceURI() == SVGNames::svgNamespaceURI.
namespaceURI() is a virtual method, and this is actually visible in profiles.
I think we can replace it with an isSVGElement() bit check.
Comment 1 Andreas Kling 2013-06-27 23:40:27 PDT 
Created attachment 205672 [details]
Patch
Comment 2 Andreas Kling 2013-10-13 00:15:58 PDT 
Committed r157360: <http://trac.webkit.org/changeset/157360>