Bug 119771 - Use NeverDestroyed for smart pointer slot static locals
Summary: Use NeverDestroyed for smart pointer slot static locals
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-13 14:47 PDT by Anders Carlsson
Modified: 2013-08-13 15:50 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.72 KB, patch)
2013-08-13 14:48 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (4.76 KB, patch)
2013-08-13 14:57 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (3.73 KB, patch)
2013-08-13 15:29 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (3.75 KB, patch)
2013-08-13 15:40 PDT, Anders Carlsson 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-08-13 14:47:27 PDT 
Use NeverDestroyed for smart pointer slot static locals
Comment 1 Anders Carlsson 2013-08-13 14:48:49 PDT 
Created attachment 208678 [details]
Patch
Comment 2 Andreas Kling 2013-08-13 14:51:41 PDT 
Comment on attachment 208678 [details]
Patch

rs=me but I can't believe these are all the sites. You should find all of them!
Comment 3 Early Warning System Bot 2013-08-13 14:53:51 PDT 
Comment on attachment 208678 [details]
Patch

Attachment 208678 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1451608
Comment 4 Early Warning System Bot 2013-08-13 14:55:15 PDT 
Comment on attachment 208678 [details]
Patch

Attachment 208678 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1446817
Comment 5 Anders Carlsson 2013-08-13 14:57:47 PDT 
Created attachment 208680 [details]
Patch
Comment 6 Early Warning System Bot 2013-08-13 15:06:36 PDT 
Comment on attachment 208680 [details]
Patch

Attachment 208680 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1445903
Comment 7 Early Warning System Bot 2013-08-13 15:10:21 PDT 
Comment on attachment 208680 [details]
Patch

Attachment 208680 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1456586
Comment 8 Anders Carlsson 2013-08-13 15:29:11 PDT 
Created attachment 208684 [details]
Patch
Comment 9 Early Warning System Bot 2013-08-13 15:32:39 PDT 
Comment on attachment 208684 [details]
Patch

Attachment 208684 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1451622
Comment 10 Early Warning System Bot 2013-08-13 15:34:59 PDT 
Comment on attachment 208684 [details]
Patch

Attachment 208684 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1461121
Comment 11 Anders Carlsson 2013-08-13 15:40:17 PDT 
Created attachment 208685 [details]
Patch
Comment 12 Anders Carlsson 2013-08-13 15:50:03 PDT 
Committed r154028: <http://trac.webkit.org/changeset/154028>