Bug 119778 - Add Canvas protocol observer
Summary: Add Canvas protocol observer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-13 17:16 PDT by Dean Jackson
Modified: 2019-12-17 09:27 PST (History)
5 users (show)

See Also:


Attachments
Patch (4.74 KB, patch)
2013-08-13 17:25 PDT, Dean Jackson
joepeck: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2013-08-13 17:16:58 PDT
Now that we're enabling Canvas profiling, we need a canvas observer to receive the events sent from the backend.
Comment 1 Radar WebKit Bug Importer 2013-08-13 17:17:13 PDT
<rdar://problem/14730691>
Comment 2 Dean Jackson 2013-08-13 17:25:21 PDT
Created attachment 208693 [details]
Patch
Comment 3 Joseph Pecoraro 2013-08-13 17:36:02 PDT
Comment on attachment 208693 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208693&action=review

r=me, with 1 comment

> Source/WebInspectorUI/UserInterface/Main.js:41
> +    InspectorBackend.registerCanvasDispatcher(new WebInspector.CanvasObserver);

InspectorBackend.registerCanvasDispatcher did not exist in iOS 6.

iOS 6 devices load the UserInterface/Legacy/6.0/InspectorBackendCommands.js file instead of the UserInterface/InspectorBackendCommands.js in LoadInspectorBackendCommands.js. So the lack of that function existing will mean that this would be an uncaught exception.

You should do this at the bottom like the LayerTreeDispatcher.

    if (InspectorBackend.registerCanvasDispatcher)
        InspectorBackend.registerCanvasDispatcher(new WebInspector.CanvasObserver);
Comment 4 Dean Jackson 2013-08-13 18:03:34 PDT
Committed r154034: <http://trac.webkit.org/changeset/154034>