Bug 119852 - Frame::scriptController() should return a reference
Summary: Frame::scriptController() should return a reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-15 11:35 PDT by Pratik Solanki
Modified: 2013-08-16 10:54 PDT (History)
5 users (show)

See Also:

Attachments
Patch 1 (100.88 KB, patch)
2013-08-15 11:47 PDT, Pratik Solanki 		no flags Details | Formatted Diff | Diff
Patch 2 - with potential qt fix (102.28 KB, patch)
2013-08-15 13:40 PDT, Pratik Solanki 		no flags Details | Formatted Diff | Diff
Patch 3 - for review and landing (111.86 KB, patch)
2013-08-15 16:46 PDT, Pratik Solanki 		kling: review+
eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2013-08-15 11:35:45 PDT 
m_script is never null so we can just return a reference.
Comment 1 Pratik Solanki 2013-08-15 11:47:49 PDT 
Created attachment 208830 [details]
Patch 1
Comment 2 Early Warning System Bot 2013-08-15 12:00:28 PDT 
Comment on attachment 208830 [details]
Patch 1

Attachment 208830 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1467297
Comment 3 Early Warning System Bot 2013-08-15 12:05:26 PDT 
Comment on attachment 208830 [details]
Patch 1

Attachment 208830 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1466361
Comment 4 EFL EWS Bot 2013-08-15 12:27:40 PDT 
Comment on attachment 208830 [details]
Patch 1

Attachment 208830 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1469272
Comment 5 Pratik Solanki 2013-08-15 13:40:37 PDT 
Created attachment 208845 [details]
Patch 2 - with potential qt fix
Comment 6 EFL EWS Bot 2013-08-15 14:25:30 PDT 
Comment on attachment 208845 [details]
Patch 2 - with potential qt fix

Attachment 208845 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1471247
Comment 7 Pratik Solanki 2013-08-15 16:46:10 PDT 
Created attachment 208869 [details]
Patch 3 - for review and landing
Comment 8 Andreas Kling 2013-08-15 16:48:58 PDT 
Comment on attachment 208869 [details]
Patch 3 - for review and landing

LGTM, assuming it builds everywhere!
Comment 9 Pratik Solanki 2013-08-15 17:17:48 PDT 
(In reply to comment #8)
> (From update of attachment 208869 [details])
> LGTM, assuming it builds everywhere!

Thanks. The previous failure on efl was not due to my patch. But I'll land this later tonight when I can monitor the bots.
Comment 10 EFL EWS Bot 2013-08-15 19:36:42 PDT 
Comment on attachment 208869 [details]
Patch 3 - for review and landing

Attachment 208869 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1473300
Comment 11 Pratik Solanki 2013-08-16 10:54:41 PDT 
Committed r154192: <http://trac.webkit.org/changeset/154192>