Bug 119871 - Flash of garbage pixels when playing a show on Hulu
Summary: Flash of garbage pixels when playing a show on Hulu
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-15 15:28 PDT by Simon Fraser (smfr)
Modified: 2013-08-15 16:17 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.84 KB, patch)
2013-08-15 15:37 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2013-08-15 15:28:41 PDT 
Flash of garbage pixels when playing a show on Hulu
Comment 1 Simon Fraser (smfr) 2013-08-15 15:29:25 PDT 
<rdar://problem/14307781>
Comment 2 Simon Fraser (smfr) 2013-08-15 15:37:32 PDT 
Created attachment 208866 [details]
Patch
Comment 3 Tim Horton 2013-08-15 15:40:09 PDT 
Comment on attachment 208866 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208866&action=review

> Source/WebCore/rendering/RenderLayerCompositor.cpp:780
> +        layer->setViewportConstrainedNotCompositedReason(RenderLayer::NoNotCompositedReason);

The code above only resets this if it's already set to not composited, and sets layerChanged (which gets returned). Does that matter? Should we do it here too?
Comment 4 Simon Fraser (smfr) 2013-08-15 16:17:27 PDT 
We don't need to set layerChanged .
http://trac.webkit.org/changeset/154147