Bug 119893 - FrameView::frame() should return a reference.
Summary: FrameView::frame() should return a reference.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-16 05:05 PDT by Andreas Kling
Modified: 2013-08-16 08:47 PDT (History)
2 users (show)

See Also:

Attachments
Patch (103.86 KB, patch)
2013-08-16 05:26 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
Patch for landing (if EWS digs) (107.88 KB, patch)
2013-08-16 06:51 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (ews plz) (112.28 KB, patch)
2013-08-16 07:02 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-16 05:05:09 PDT 
With some minor tweaking, FrameView::frame() can be guaranteed to never return null.
Comment 1 Andreas Kling 2013-08-16 05:26:38 PDT 
Created attachment 208919 [details]
Patch
Comment 2 Antti Koivisto 2013-08-16 05:39:26 PDT 
Comment on attachment 208919 [details]
Patch

r=me when you get it to build.
Comment 3 Andreas Kling 2013-08-16 06:51:50 PDT 
Created attachment 208922 [details]
Patch for landing (if EWS digs)
Comment 4 Early Warning System Bot 2013-08-16 06:58:14 PDT 
Comment on attachment 208922 [details]
Patch for landing (if EWS digs)

Attachment 208922 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1470526
Comment 5 Early Warning System Bot 2013-08-16 07:00:13 PDT 
Comment on attachment 208922 [details]
Patch for landing (if EWS digs)

Attachment 208922 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1479050
Comment 6 Andreas Kling 2013-08-16 07:02:41 PDT 
Created attachment 208923 [details]
Patch for landing (ews plz)
Comment 7 Andreas Kling 2013-08-16 08:47:29 PDT 
Committed r154184: <http://trac.webkit.org/changeset/154184>