Bug 119936 - Fix some encapsulation issues of RuleSet
Summary: Fix some encapsulation issues of RuleSet
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-16 22:47 PDT by Benjamin Poulain
Modified: 2013-08-19 14:42 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.25 KB, patch)
2013-08-16 22:52 PDT, Benjamin Poulain 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2013-08-16 22:47:06 PDT 
Fix some encapsulation issues of RuleSet
Comment 1 Benjamin Poulain 2013-08-16 22:52:50 PDT 
Created attachment 208979 [details]
Patch
Comment 2 Darin Adler 2013-08-17 05:13:48 PDT 
Comment on attachment 208979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=208979&action=review

> Source/WebCore/css/RuleSet.h:111
> +        RuleSetSelectorPair(const RuleSetSelectorPair& rs) : selector(rs.selector), ruleSet(const_cast<RuleSetSelectorPair*>(&rs)->ruleSet.release()) { }

I think the word “pair” would be better than “rs” for this variable name.

I think it’s awkward to write this as a copy constructor instead of a move constructor.

Looks like you are just moving this code, though.
Comment 3 Benjamin Poulain 2013-08-19 14:42:07 PDT 
Committed r154299: <http://trac.webkit.org/changeset/154299>