Bug 119952 - Simplify Editor's back-pointer to the Frame.
Summary: Simplify Editor's back-pointer to the Frame.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-17 10:06 PDT by Andreas Kling
Modified: 2013-08-17 10:33 PDT (History)
2 users (show)

See Also:


Attachments
Patch (85.75 KB, patch)
2013-08-17 10:11 PDT, Andreas Kling
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-17 10:06:58 PDT
Simplify Editor's back-pointer to the Frame.
Comment 1 Andreas Kling 2013-08-17 10:11:08 PDT
Created attachment 209002 [details]
Patch
Comment 2 WebKit Commit Bot 2013-08-17 10:13:19 PDT
Attachment 209002 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/Editor.h', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/ios/EditorIOS.mm', u'Source/WebCore/editing/mac/EditorMac.mm', u'Source/WebCore/page/Frame.cpp']" exit_code: 1
Source/WebCore/editing/Editor.cpp:1540:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/editing/Editor.cpp:2520:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-08-17 10:33:13 PDT
Committed r154237: <http://trac.webkit.org/changeset/154237>