Bug 119960 - Remove some optimizations made obsolete by use of StringBuilder
Summary: Remove some optimizations made obsolete by use of StringBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-17 14:36 PDT by Antti Koivisto
Modified: 2013-08-17 15:04 PDT (History)
3 users (show)

See Also:


Attachments
pathc (3.24 KB, patch)
2013-08-17 14:41 PDT, Antti Koivisto
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-08-17 14:36:27 PDT
Foo.
Comment 1 Antti Koivisto 2013-08-17 14:41:54 PDT
Created attachment 209009 [details]
pathc
Comment 2 Andreas Kling 2013-08-17 14:48:02 PDT
Comment on attachment 209009 [details]
pathc

View in context: https://bugs.webkit.org/attachment.cgi?id=209009&action=review

r=me with the cool stories we shared on IRC.

We should clean this up in StyleElement::process(), too.

> Source/WebCore/dom/ScriptElement.cpp:399
> +    for (Text* textNode = TextNodeTraversal::firstChild(m_element); textNode; textNode = TextNodeTraversal::nextSibling(textNode))
> +        content.append(textNode->data());

Can't you use TextNodeTraversal::contentsAsString() instead here?
Comment 3 Antti Koivisto 2013-08-17 15:04:51 PDT
https://trac.webkit.org/r154241