Bug 120009 - [GTK] Stop button should be added to MiniBrowser
Summary: [GTK] Stop button should be added to MiniBrowser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Linux
: P2 Normal
Assignee: Anton Obzhirov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-19 07:21 PDT by Anton Obzhirov
Modified: 2013-08-20 03:59 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.34 KB, patch)
2013-08-19 09:24 PDT, Anton Obzhirov 		no flags Details | Formatted Diff | Diff
Patch (3.75 KB, patch)
2013-08-20 02:36 PDT, Anton Obzhirov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anton Obzhirov 2013-08-19 07:21:13 PDT 
My suggestion is to replace reload button with stop button during loading of the page.
Comment 1 Anton Obzhirov 2013-08-19 09:24:51 PDT 
Created attachment 209092 [details]
Patch
Comment 2 Martin Robinson 2013-08-19 10:07:37 PDT 
Comment on attachment 209092 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209092&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:589
>      item = gtk_tool_button_new_from_stock(GTK_STOCK_REFRESH);
> -    g_signal_connect_swapped(item, "clicked", G_CALLBACK(reloadCallback), window);
> +    g_signal_connect_swapped(item, "clicked", G_CALLBACK(reloadOrStopCallback), window);
>      gtk_toolbar_insert(GTK_TOOLBAR(toolbar), item, -1);
>      gtk_widget_add_accelerator(GTK_WIDGET(item), "clicked", accelGroup, GDK_KEY_F5, 0, GTK_ACCEL_VISIBLE);
>      gtk_widget_show(GTK_WIDGET(item));
> +    reloadOrStopButton = item;

Probably better just to use reloadOrStopButton instead of item here.
Comment 3 Anton Obzhirov 2013-08-20 02:36:50 PDT 
Created attachment 209174 [details]
Patch

Updated with Martin's comments
Comment 4 WebKit Commit Bot 2013-08-20 03:59:09 PDT 
Comment on attachment 209174 [details]
Patch

Clearing flags on attachment: 209174

Committed r154322: <http://trac.webkit.org/changeset/154322>
Comment 5 WebKit Commit Bot 2013-08-20 03:59:12 PDT 
All reviewed patches have been landed.  Closing bug.