Bug 120048 - [GTK] Add stubs for APIs that went missing in the DOM bindings
Summary: [GTK] Add stubs for APIs that went missing in the DOM bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gustavo Noronha (kov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-19 18:47 PDT by Gustavo Noronha (kov)
Modified: 2013-08-20 08:51 PDT (History)
6 users (show)

See Also:


Attachments
Patch (28.07 KB, patch)
2013-08-19 18:50 PDT, Gustavo Noronha (kov)
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gustavo Noronha (kov) 2013-08-19 18:47:22 PDT
[GTK] Add stubs for APIs that went missing in the DOM bindings
Comment 1 Gustavo Noronha (kov) 2013-08-19 18:50:18 PDT
Created attachment 209147 [details]
Patch
Comment 2 Martin Robinson 2013-08-19 21:03:22 PDT
Comment on attachment 209147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209147&action=review

This is a pretty impressively large collection of API.

> Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:164
> +gboolean
> +webkit_dom_bar_info_get_visible(void*)

I think in the implementation itself we want to avoid the double-line function definition.
Comment 3 Gustavo Noronha (kov) 2013-08-20 08:04:18 PDT
(In reply to comment #2)
> (From update of attachment 209147 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=209147&action=review
> 
> This is a pretty impressively large collection of API.

It is =/. Thank goodness for the debian symbols checking tools.

> > Source/WebCore/bindings/gobject/WebKitDOMCustom.cpp:164
> > +gboolean
> > +webkit_dom_bar_info_get_visible(void*)
> 
> I think in the implementation itself we want to avoid the double-line function definition.

Indeed, I'll change that and land, thanks!
Comment 4 Gustavo Noronha (kov) 2013-08-20 08:51:38 PDT
Committed r154328: <http://trac.webkit.org/changeset/154328>