Bug 120076 - remove more obj32 directory references
Summary: remove more obj32 directory references
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P3 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-20 11:44 PDT by Alex Christensen
Modified: 2013-08-20 13:44 PDT (History)
1 user (show)

See Also:

Attachments
Patch (10.37 KB, patch)
2013-08-20 11:55 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (10.35 KB, patch)
2013-08-20 12:00 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (8.29 KB, patch)
2013-08-20 13:01 PDT, Alex Christensen 		bfulgham: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-08-20 11:44:57 PDT 
After https://bugs.webkit.org/show_bug.cgi?id=119512 there are still many places where obj32, lib32, and bin32 are hard-coded into scripts.  These should all be replaced by the PlatformArchitecture macro.  I still haven't done this everywhere, but this represents a step in the right direction.
Comment 1 Alex Christensen 2013-08-20 11:55:18 PDT 
Created attachment 209214 [details]
Patch
Comment 2 Alex Christensen 2013-08-20 11:56:46 PDT 
This builds completely, runs, and doesn't seem to break anything.
Comment 3 Alex Christensen 2013-08-20 12:00:14 PDT 
Created attachment 209217 [details]
Patch
Comment 4 Alex Christensen 2013-08-20 13:01:56 PDT 
Created attachment 209221 [details]
Patch
Comment 5 Brent Fulgham 2013-08-20 13:22:22 PDT 
Comment on attachment 209221 [details]
Patch

Nice! r=mw
Comment 6 Alex Christensen 2013-08-20 13:44:31 PDT 
r154354