Bug 120165 - Web Inspector: Update CodeMirror to 3.16.1
Summary: Web Inspector: Update CodeMirror to 3.16.1
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-22 11:52 PDT by Joseph Pecoraro
Modified: 2013-08-22 12:27 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (78.01 KB, patch)
2013-08-22 11:55 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-08-22 11:52:37 PDT 
Update of CodeMirror to get "gutterContextMenu" event.

Updating the CodeMirror Resources is mostly automated:

  1. Update local CodeMirror checkout ($codemirror)
  shell> cd $codemirror; git pull --rebase

  2. Update WebInspectorUI CodeMirror resources:
  shell>./Source/WebInspectorUI/Scripts/update-codemirror-resources.rb $codemirror

  3. Update WebInspectorUI Tools/PrettyPrintingr CodeMirror resources and run tests:
  shell>./Source/WebInspectorUI/Scripts/update-pretty-printer.rb Tools
  shell> open ./Source/WebInspectorUI/Tools/PrettyPrinting/index.html # run tests in the UI

  4. Do some manual testing of the inspector to make sure things work as expected
Comment 1 Radar WebKit Bug Importer 2013-08-22 11:52:58 PDT 
<rdar://problem/14810479>
Comment 2 Joseph Pecoraro 2013-08-22 11:55:10 PDT 
Created attachment 209381 [details]
[PATCH] Proposed Fix

• All Tools/PrettyPrinting tests passed.
• General testing looked good (Styles sidebar, Console prompt, CSS Resource editing)
Comment 3 WebKit Commit Bot 2013-08-22 12:27:54 PDT 
Comment on attachment 209381 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 209381

Committed r154456: <http://trac.webkit.org/changeset/154456>
Comment 4 WebKit Commit Bot 2013-08-22 12:27:56 PDT 
All reviewed patches have been landed.  Closing bug.