Bug 120166 - Add Traversal<ElementType> template
Summary: Add Traversal<ElementType> template
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-22 12:02 PDT by Antti Koivisto
Modified: 2013-08-23 05:41 PDT (History)
4 users (show)

See Also:

Attachments
patch (64.53 KB, patch)
2013-08-22 12:11 PDT, Antti Koivisto 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
another (67.56 KB, patch)
2013-08-22 13:53 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
yet another (66.37 KB, patch)
2013-08-22 15:27 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
yet yet another (66.42 KB, patch)
2013-08-22 16:17 PDT, Antti Koivisto 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (523.72 KB, application/zip)
2013-08-22 17:24 PDT, Build Bot 		no flags Details
more (66.39 KB, patch)
2013-08-23 00:09 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-08-22 12:02:39 PDT 
It is common to traverse through a subtree looking for elements of specific type and then casting to the type. This pattern can be generalized.
Comment 1 Antti Koivisto 2013-08-22 12:11:08 PDT 
Created attachment 209383 [details]
patch
Comment 2 Early Warning System Bot 2013-08-22 12:19:27 PDT 
Comment on attachment 209383 [details]
patch

Attachment 209383 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1546032
Comment 3 Early Warning System Bot 2013-08-22 12:20:09 PDT 
Comment on attachment 209383 [details]
patch

Attachment 209383 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1543084
Comment 4 EFL EWS Bot 2013-08-22 12:20:12 PDT 
Comment on attachment 209383 [details]
patch

Attachment 209383 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1527350
Comment 5 Antti Koivisto 2013-08-22 13:53:09 PDT 
Created attachment 209390 [details]
another
Comment 6 Antti Koivisto 2013-08-22 15:27:41 PDT 
Created attachment 209398 [details]
yet another
Comment 7 Antti Koivisto 2013-08-22 16:17:25 PDT 
Created attachment 209403 [details]
yet yet another
Comment 8 Build Bot 2013-08-22 17:24:46 PDT 
Comment on attachment 209403 [details]
yet yet another

Attachment 209403 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1555063

New failing tests:
fast/parser/style-in-create-contextual-fragment-head.html
fast/workers/termination-with-port-messages.html
fast/parser/style-in-create-contextual-fragment.html
Comment 9 Build Bot 2013-08-22 17:24:47 PDT 
Created attachment 209411 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.4
Comment 10 Antti Koivisto 2013-08-23 00:09:15 PDT 
Created attachment 209440 [details]
more
Comment 11 Andreas Kling 2013-08-23 04:48:47 PDT 
Comment on attachment 209440 [details]
more

r=me

We really should auto-generate the isFooElement() helpers.
Comment 12 Antti Koivisto 2013-08-23 05:41:02 PDT 
https://trac.webkit.org/r154481