Bug 120339 - FocusController::focusedOrMainFrame() should return a reference.
Summary: FocusController::focusedOrMainFrame() should return a reference.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-26 20:33 PDT by Andreas Kling
Modified: 2013-08-27 05:59 PDT (History)
8 users (show)

See Also:

Attachments
Patch (120.44 KB, patch)
2013-08-26 20:37 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (120.58 KB, patch)
2013-08-26 20:53 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (120.77 KB, patch)
2013-08-26 21:05 PDT, Andreas Kling 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (121.60 KB, patch)
2013-08-27 05:18 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-26 20:33:09 PDT 
FocusController::focusedOrMainFrame() should return a reference.
Comment 1 Andreas Kling 2013-08-26 20:37:26 PDT 
Created attachment 209711 [details]
Patch

I'm sure EWS will hate it. I like it though.
Comment 2 Early Warning System Bot 2013-08-26 20:42:31 PDT 
Comment on attachment 209711 [details]
Patch

Attachment 209711 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1590139
Comment 3 EFL EWS Bot 2013-08-26 20:42:56 PDT 
Comment on attachment 209711 [details]
Patch

Attachment 209711 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1578160
Comment 4 Early Warning System Bot 2013-08-26 20:42:59 PDT 
Comment on attachment 209711 [details]
Patch

Attachment 209711 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1582153
Comment 5 Andreas Kling 2013-08-26 20:53:35 PDT 
Created attachment 209713 [details]
Patch
Comment 6 Early Warning System Bot 2013-08-26 20:58:27 PDT 
Comment on attachment 209713 [details]
Patch

Attachment 209713 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1589136
Comment 7 EFL EWS Bot 2013-08-26 20:58:59 PDT 
Comment on attachment 209713 [details]
Patch

Attachment 209713 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1581145
Comment 8 Early Warning System Bot 2013-08-26 20:59:18 PDT 
Comment on attachment 209713 [details]
Patch

Attachment 209713 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1586135
Comment 9 kov's GTK+ EWS bot 2013-08-26 21:00:54 PDT 
Comment on attachment 209713 [details]
Patch

Attachment 209713 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1578166
Comment 10 Andreas Kling 2013-08-26 21:05:16 PDT 
Created attachment 209714 [details]
Patch
Comment 11 EFL EWS Bot 2013-08-26 21:11:20 PDT 
Comment on attachment 209714 [details]
Patch

Attachment 209714 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1578170
Comment 12 Early Warning System Bot 2013-08-26 21:11:44 PDT 
Comment on attachment 209714 [details]
Patch

Attachment 209714 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1583139
Comment 13 Darin Adler 2013-08-26 21:50:16 PDT 
/mnt/eflews/webkit/WebKit/Source/WebKit/efl/ewk/ewk_view.cpp: In function 'Evas_Object* ewk_view_frame_focused_get(const Evas_Object*)':
/mnt/eflews/webkit/WebKit/Source/WebKit/efl/ewk/ewk_view.cpp:1400:94: error: request for member 'loader' in 'core', which is of pointer type 'WebCore::Frame*' (maybe you meant to use '->' ?)

/home/webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp: In member function 'WebKit::EditorState WebKit::WebPage::editorState() const':
/home/webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:615:35: error: base operand of '->' has non-pointer type 'WebCore::Frame'
and more of the same
Comment 14 Build Bot 2013-08-27 04:10:49 PDT 
Comment on attachment 209714 [details]
Patch

Attachment 209714 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1579257
Comment 15 Andreas Kling 2013-08-27 05:18:34 PDT 
Created attachment 209750 [details]
Patch
Comment 16 Antti Koivisto 2013-08-27 05:51:46 PDT 
Comment on attachment 209750 [details]
Patch

r=me
Comment 17 Andreas Kling 2013-08-27 05:59:41 PDT 
Committed r154678: <http://trac.webkit.org/changeset/154678>