Bug 120365 - Remove unnecessary RenderView.h inclusion from headers.
Summary: Remove unnecessary RenderView.h inclusion from headers.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-27 08:06 PDT by Andreas Kling
Modified: 2013-09-04 15:27 PDT (History)
4 users (show)

See Also:

Attachments
poch (3.21 KB, patch)
2013-08-27 08:07 PDT, Andreas Kling 		andersca: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch för landning (3.60 KB, patch)
2013-08-27 08:14 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch før lænding (4.44 KB, patch)
2013-08-27 08:30 PDT, Andreas Kling 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Still landable? (4.40 KB, patch)
2013-09-04 13:34 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-27 08:06:32 PDT 
Remove unnecessary RenderView.h inclusion from headers.
Comment 1 Andreas Kling 2013-08-27 08:07:02 PDT 
Created attachment 209775 [details]
poch
Comment 2 WebKit Commit Bot 2013-08-27 08:08:35 PDT 
Attachment 209775 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderQuote.cpp', u'Source/WebCore/rendering/RenderText.h', u'Source/WebCore/rendering/RenderTextTrackCue.cpp', u'Source/WebCore/rendering/RenderTextTrackCue.h', u'Source/WebCore/style/StyleResolveTree.cpp']" exit_code: 1
Source/WebCore/style/StyleResolveTree.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Early Warning System Bot 2013-08-27 08:12:29 PDT 
Comment on attachment 209775 [details]
poch

Attachment 209775 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1579317
Comment 4 Early Warning System Bot 2013-08-27 08:12:42 PDT 
Comment on attachment 209775 [details]
poch

Attachment 209775 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1587311
Comment 5 Andreas Kling 2013-08-27 08:14:23 PDT 
Created attachment 209776 [details]
Patch för landning
Comment 6 Early Warning System Bot 2013-08-27 08:18:12 PDT 
Comment on attachment 209776 [details]
Patch för landning

Attachment 209776 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1588329
Comment 7 Early Warning System Bot 2013-08-27 08:19:38 PDT 
Comment on attachment 209776 [details]
Patch för landning

Attachment 209776 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1581312
Comment 8 EFL EWS Bot 2013-08-27 08:30:22 PDT 
Comment on attachment 209776 [details]
Patch för landning

Attachment 209776 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1581316
Comment 9 Andreas Kling 2013-08-27 08:30:46 PDT 
Created attachment 209777 [details]
Patch før lænding
Comment 10 Build Bot 2013-08-27 13:15:07 PDT 
Comment on attachment 209777 [details]
Patch før lænding

Attachment 209777 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1620026
Comment 11 Andreas Kling 2013-09-04 13:34:40 PDT 
Created attachment 210488 [details]
Still landable?
Comment 12 WebKit Commit Bot 2013-09-04 15:27:47 PDT 
Comment on attachment 210488 [details]
Still landable?

Clearing flags on attachment: 210488

Committed r155074: <http://trac.webkit.org/changeset/155074>
Comment 13 WebKit Commit Bot 2013-09-04 15:27:49 PDT 
All reviewed patches have been landed.  Closing bug.