Page::pluginData() should return a reference.
Created attachment 209826 [details] Patch
Comment on attachment 209826 [details] Patch Attachment 209826 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1621096
Comment on attachment 209826 [details] Patch Attachment 209826 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1591394
Created attachment 209827 [details] Patch
Comment on attachment 209827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209827&action=review > Source/WebCore/loader/SubframeLoader.cpp:197 > + const PluginData& pluginData = page->pluginData(); > + String pluginFile = pluginData.pluginFileForMimeType(newMIMEType); Local variable not needed here. The old code had it to help it check against null. > Source/WebCore/loader/SubframeLoader.cpp:418 > + const PluginData& pluginData = m_frame->page()->pluginData(); > + String pluginName = pluginData.pluginNameForMimeType(mimeType); Local variable not needed here. The old code had it to help it check against null. > Source/WebKit2/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:1408 > + const PluginData& pluginData = webPage->corePage()->pluginData(); > + if (pluginSupportsExtension(pluginData, extension)) Local variable not needed here. The old code had it to help it check against null.
Created attachment 209875 [details] Patch
Comment on attachment 209875 [details] Patch Clearing flags on attachment: 209875 Committed r154743: <http://trac.webkit.org/changeset/154743>
All reviewed patches have been landed. Closing bug.