120496 – Node::document() should return a reference.

Bug 120496 - Node::document() should return a reference.

Summary: Node::document() should return a reference.

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	DOM (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Andreas Kling

URL:
Keywords:

Depends on:
Blocks:

Reported:	2013-08-29 15:04 PDT by Andreas Kling
Modified:	2013-08-30 07:29 PDT (History)
CC List:	17 users (show)

See Also:

Attachments
EWS experiment 1 (696.97 KB, patch) 2013-08-29 15:17 PDT, Andreas Kling	webkit-ews: commit-queue-	Details \| Formatted Diff \| Diff
EWS experiment 2 (719.11 KB, patch) 2013-08-29 15:35 PDT, Andreas Kling	webkit-ews: commit-queue-	Details \| Formatted Diff \| Diff
EWS experiment 3 (724.02 KB, patch) 2013-08-29 16:03 PDT, Andreas Kling	webkit-ews: commit-queue-	Details \| Formatted Diff \| Diff
EWS experiment 4 (728.09 KB, patch) 2013-08-29 16:48 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
EWS experiment 5 (728.91 KB, patch) 2013-08-29 17:14 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
EWS experiment 6 (728.91 KB, patch) 2013-08-29 17:28 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
EWS experiment 7 (732.48 KB, patch) 2013-08-29 19:19 PDT, Andreas Kling	eflews.bot: commit-queue-	Details \| Formatted Diff \| Diff
EWS experiment 8 (737.87 KB, patch) 2013-08-29 19:51 PDT, Andreas Kling	eflews.bot: commit-queue-	Details \| Formatted Diff \| Diff
EWS experiment 9 (738.85 KB, patch) 2013-08-29 20:53 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
EWS experiment 10 (1.80 KB, patch) 2013-08-29 21:10 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
EWS experiment 10 (740.65 KB, patch) 2013-08-29 21:11 PDT, Andreas Kling	eflews.bot: commit-queue-	Details \| Formatted Diff \| Diff
EWS experiment 11 (6.44 KB, patch) 2013-08-29 22:10 PDT, Andreas Kling	eflews.bot: commit-queue-	Details \| Formatted Diff \| Diff
EWS experiment 12 (745.95 KB, patch) 2013-08-30 05:38 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
EWS experiment 13 (747.42 KB, patch) 2013-08-30 05:56 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
Patch (748.10 KB, patch) 2013-08-30 07:12 PDT, Andreas Kling	koivisto: review+ koivisto: commit-queue-	Details \| Formatted Diff \| Diff
Show Obsolete (14) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andreas Kling 2013-08-29 15:04:33 PDT

#awyiss

Comment 1 Andreas Kling 2013-08-29 15:17:00 PDT

Created attachment 210036 [details]
EWS experiment 1

Comment 2 WebKit Commit Bot 2013-08-29 15:19:19 PDT

Attachment 210036 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/accessibility/AXObjectCache.cpp', u'Source/WebCore/accessibility/AccessibilityImageMapLink.cpp', u'Source/WebCore/accessibility/AccessibilityListBoxOption.cpp', u'Source/WebCore/accessibility/AccessibilityNodeObject.cpp', u'Source/WebCore/accessibility/AccessibilityObject.cpp', u'Source/WebCore/accessibility/AccessibilityRenderObject.cpp', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm', u'Source/WebCore/bindings/generic/BindingSecurity.cpp', u'Source/WebCore/bindings/js/JSHTMLCanvasElementCustom.cpp', u'Source/WebCore/bindings/js/JSHTMLElementCustom.cpp', u'Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.cpp', u'Source/WebCore/bindings/js/JSNodeCustom.h', u'Source/WebCore/bindings/js/ScriptEventListener.cpp', u'Source/WebCore/bindings/js/ScriptState.cpp', u'Source/WebCore/bindings/objc/DOM.mm', u'Source/WebCore/bindings/objc/DOMHTML.mm', u'Source/WebCore/bindings/objc/DOMInternal.mm', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/CSSCursorImageValue.cpp', u'Source/WebCore/css/CSSDefaultStyleSheets.cpp', u'Source/WebCore/css/CSSParser.cpp', u'Source/WebCore/css/CSSStyleSheet.cpp', u'Source/WebCore/css/DeprecatedStyleBuilder.cpp', u'Source/WebCore/css/PropertySetCSSStyleDeclaration.cpp', u'Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp', u'Source/WebCore/css/SelectorChecker.cpp', u'Source/WebCore/css/StyleResolver.cpp', u'Source/WebCore/css/StyleResolver.h', u'Source/WebCore/css/StyleSheetContents.cpp', u'Source/WebCore/dom/Attr.cpp', u'Source/WebCore/dom/CDATASection.cpp', u'Source/WebCore/dom/CharacterData.cpp', u'Source/WebCore/dom/ChildListMutationScope.h', u'Source/WebCore/dom/ClipboardMac.mm', u'Source/WebCore/dom/Comment.cpp', u'Source/WebCore/dom/ContainerNode.cpp', u'Source/WebCore/dom/ContainerNodeAlgorithms.cpp', u'Source/WebCore/dom/ContainerNodeAlgorithms.h', u'Source/WebCore/dom/DescendantIteratorAssertions.h', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/dom/Document.h', u'Source/WebCore/dom/DocumentEventQueue.cpp', u'Source/WebCore/dom/DocumentFragment.cpp', u'Source/WebCore/dom/DocumentStyleSheetCollection.cpp', u'Source/WebCore/dom/DocumentType.cpp', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/EntityReference.cpp', u'Source/WebCore/dom/EventDispatcher.cpp', u'Source/WebCore/dom/EventRetargeter.cpp', u'Source/WebCore/dom/EventTarget.h', u'Source/WebCore/dom/InlineStyleSheetOwner.cpp', u'Source/WebCore/dom/LiveNodeList.cpp', u'Source/WebCore/dom/LiveNodeList.h', u'Source/WebCore/dom/MouseEvent.cpp', u'Source/WebCore/dom/MouseRelatedEvent.cpp', u'Source/WebCore/dom/MutationObserverInterestGroup.h', u'Source/WebCore/dom/NamedNodeMap.cpp', u'Source/WebCore/dom/Node.cpp', u'Source/WebCore/dom/Node.h', u'Source/WebCore/dom/NodeIterator.cpp', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/dom/Position.h', u'Source/WebCore/dom/ProcessingInstruction.cpp', u'Source/WebCore/dom/PseudoElement.cpp', u'Source/WebCore/dom/Range.cpp', u'Source/WebCore/dom/ScriptElement.cpp', u'Source/WebCore/dom/SelectorQuery.cpp', u'Source/WebCore/dom/StyledElement.cpp', u'Source/WebCore/dom/Text.cpp', u'Source/WebCore/dom/TreeScope.cpp', u'Source/WebCore/dom/VisitedLinkState.cpp', u'Source/WebCore/dom/make_names.pl', u'Source/WebCore/editing/AlternativeTextController.cpp', u'Source/WebCore/editing/AppendNodeCommand.cpp', u'Source/WebCore/editing/ApplyStyleCommand.cpp', u'Source/WebCore/editing/DeleteButton.cpp', u'Source/WebCore/editing/DeleteButtonController.cpp', u'Source/WebCore/editing/DeleteFromTextNodeCommand.cpp', u'Source/WebCore/editing/DeleteSelectionCommand.cpp', u'Source/WebCore/editing/DictationCommand.cpp', u'Source/WebCore/editing/EditingStyle.cpp', u'Source/WebCore/editing/Editor.cpp', u'Source/WebCore/editing/EditorCommand.cpp', u'Source/WebCore/editing/FrameSelection.cpp', u'Source/WebCore/editing/InsertIntoTextNodeCommand.cpp', u'Source/WebCore/editing/InsertListCommand.cpp', u'Source/WebCore/editing/InsertNodeBeforeCommand.cpp', u'Source/WebCore/editing/InsertParagraphSeparatorCommand.cpp', u'Source/WebCore/editing/MarkupAccumulator.cpp', u'Source/WebCore/editing/MergeIdenticalElementsCommand.cpp', u'Source/WebCore/editing/MoveSelectionCommand.cpp', u'Source/WebCore/editing/RemoveNodeCommand.cpp', u'Source/WebCore/editing/RemoveNodePreservingChildrenCommand.cpp', u'Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp', u'Source/WebCore/editing/SetNodeAttributeCommand.cpp', u'Source/WebCore/editing/SetSelectionCommand.cpp', u'Source/WebCore/editing/SpellingCorrectionCommand.cpp', u'Source/WebCore/editing/SplitElementCommand.cpp', u'Source/WebCore/editing/SplitTextNodeCommand.cpp', u'Source/WebCore/editing/SplitTextNodeContainingElementCommand.cpp', u'Source/WebCore/editing/TextCheckingHelper.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/VisiblePosition.cpp', u'Source/WebCore/editing/VisibleSelection.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/editing/WrapContentsInDummySpanCommand.cpp', u'Source/WebCore/editing/htmlediting.cpp', u'Source/WebCore/editing/markup.cpp', u'Source/WebCore/html/ClassList.cpp', u'Source/WebCore/html/ColorInputType.cpp', u'Source/WebCore/html/FileInputType.cpp', u'Source/WebCore/html/FormAssociatedElement.cpp', u'Source/WebCore/html/HTMLAnchorElement.cpp', u'Source/WebCore/html/HTMLAnchorElement.h', u'Source/WebCore/html/HTMLAppletElement.cpp', u'Source/WebCore/html/HTMLAreaElement.cpp', u'Source/WebCore/html/HTMLBaseElement.cpp', u'Source/WebCore/html/HTMLBodyElement.cpp', u'Source/WebCore/html/HTMLCanvasElement.cpp', u'Source/WebCore/html/HTMLDetailsElement.cpp', u'Source/WebCore/html/HTMLElement.cpp', u'Source/WebCore/html/HTMLEmbedElement.cpp', u'Source/WebCore/html/HTMLFieldSetElement.cpp', u'Source/WebCore/html/HTMLFormControlElement.cpp', u'Source/WebCore/html/HTMLFormControlElementWithState.cpp', u'Source/WebCore/html/HTMLFormElement.cpp', u'Source/WebCore/html/HTMLFrameElementBase.cpp', u'Source/WebCore/html/HTMLFrameSetElement.cpp', u'Source/WebCore/html/HTMLHtmlElement.cpp', u'Source/WebCore/html/HTMLIFrameElement.cpp', u'Source/WebCore/html/HTMLImageElement.cpp', u'Source/WebCore/html/HTMLImageLoader.cpp', u'Source/WebCore/html/HTMLInputElement.cpp', u'Source/WebCore/html/HTMLKeygenElement.cpp', u'Source/WebCore/html/HTMLLabelElement.cpp', u'Source/WebCore/html/HTMLLinkElement.cpp', u'Source/WebCore/html/HTMLMapElement.cpp', u'Source/WebCore/html/HTMLMediaElement.cpp', u'Source/WebCore/html/HTMLMetaElement.cpp', u'Source/WebCore/html/HTMLMeterElement.cpp', u'Source/WebCore/html/HTMLObjectElement.cpp', u'Source/WebCore/html/HTMLOptGroupElement.cpp', u'Source/WebCore/html/HTMLOptionElement.cpp', u'Source/WebCore/html/HTMLParamElement.cpp', u'Source/WebCore/html/HTMLPlugInElement.cpp', u'Source/WebCore/html/HTMLPlugInImageElement.cpp', u'Source/WebCore/html/HTMLProgressElement.cpp', u'Source/WebCore/html/HTMLQuoteElement.cpp', u'Source/WebCore/html/HTMLScriptElement.cpp', u'Source/WebCore/html/HTMLSelectElement.cpp', u'Source/WebCore/html/HTMLStyleElement.cpp', u'Source/WebCore/html/HTMLStyleElement.h', u'Source/WebCore/html/HTMLSummaryElement.cpp', u'Source/WebCore/html/HTMLTableCellElement.cpp', u'Source/WebCore/html/HTMLTableElement.cpp', u'Source/WebCore/html/HTMLTablePartElement.cpp', u'Source/WebCore/html/HTMLTableRowElement.cpp', u'Source/WebCore/html/HTMLTableSectionElement.cpp', u'Source/WebCore/html/HTMLTextAreaElement.cpp', u'Source/WebCore/html/HTMLTextFormControlElement.cpp', u'Source/WebCore/html/HTMLTitleElement.cpp', u'Source/WebCore/html/HTMLTrackElement.cpp', u'Source/WebCore/html/HTMLVideoElement.cpp', u'Source/WebCore/html/ImageInputType.cpp', u'Source/WebCore/html/InputType.cpp', u'Source/WebCore/html/LabelableElement.cpp', u'Source/WebCore/html/RadioInputType.cpp', u'Source/WebCore/html/RangeInputType.cpp', u'Source/WebCore/html/SearchInputType.cpp', u'Source/WebCore/html/TextFieldInputType.cpp', u'Source/WebCore/html/ValidationMessage.cpp', u'Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp', u'Source/WebCore/html/canvas/CanvasStyle.cpp', u'Source/WebCore/html/canvas/WebGLRenderingContext.cpp', u'Source/WebCore/html/parser/HTMLConstructionSite.cpp', u'Source/WebCore/html/parser/HTMLDocumentParser.cpp', u'Source/WebCore/html/shadow/MediaControlElements.cpp', u'Source/WebCore/html/shadow/MediaControls.cpp', u'Source/WebCore/html/shadow/MediaControlsApple.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.cpp', u'Source/WebCore/html/shadow/SliderThumbElement.h', u'Source/WebCore/html/shadow/SpinButtonElement.cpp', u'Source/WebCore/html/shadow/TextControlInnerElements.cpp', u'Source/WebCore/html/track/LoadableTextTrack.cpp', u'Source/WebCore/html/track/WebVTTElement.cpp', u'Source/WebCore/inspector/DOMEditor.cpp', u'Source/WebCore/inspector/DOMPatchSupport.cpp', u'Source/WebCore/inspector/InspectorCSSAgent.cpp', u'Source/WebCore/inspector/InspectorDOMAgent.cpp', u'Source/WebCore/inspector/InspectorInstrumentation.h', u'Source/WebCore/inspector/InspectorLayerTreeAgent.cpp', u'Source/WebCore/inspector/InspectorOverlay.cpp', u'Source/WebCore/inspector/InspectorStyleSheet.cpp', u'Source/WebCore/loader/FormSubmission.cpp', u'Source/WebCore/loader/ImageLoader.cpp', u'Source/WebCore/loader/PolicyChecker.cpp', u'Source/WebCore/loader/SubframeLoader.cpp', u'Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp', u'Source/WebCore/mathml/MathMLMathElement.cpp', u'Source/WebCore/page/Chrome.cpp', u'Source/WebCore/page/ContextMenuController.cpp', u'Source/WebCore/page/DOMSelection.cpp', u'Source/WebCore/page/DragController.cpp', u'Source/WebCore/page/EventHandler.cpp', u'Source/WebCore/page/FocusController.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/PrintContext.cpp', u'Source/WebCore/page/SpatialNavigation.cpp', u'Source/WebCore/page/SpatialNavigation.h', u'Source/WebCore/page/TouchAdjustment.cpp', u'Source/WebCore/page/animation/AnimationBase.cpp', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/page/animation/ImplicitAnimation.cpp', u'Source/WebCore/page/animation/KeyframeAnimation.cpp', u'Source/WebCore/page/mac/DragControllerMac.mm', u'Source/WebCore/platform/gtk/PasteboardGtk.cpp', u'Source/WebCore/platform/mac/HTMLConverter.mm', u'Source/WebCore/platform/mac/PasteboardMac.mm', u'Source/WebCore/rendering/HitTestResult.cpp', u'Source/WebCore/rendering/RenderIFrame.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerFilterInfo.cpp', u'Source/WebCore/rendering/RenderListBox.cpp', u'Source/WebCore/rendering/RenderMenuList.cpp', u'Source/WebCore/rendering/RenderNamedFlowThread.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/rendering/RenderTheme.cpp', u'Source/WebCore/rendering/RenderThemeWin.cpp', u'Source/WebCore/rendering/RenderTreeAsText.cpp', u'Source/WebCore/rendering/RenderVideo.cpp', u'Source/WebCore/rendering/RenderView.cpp', u'Source/WebCore/rendering/RenderWidget.cpp', u'Source/WebCore/rendering/svg/RenderSVGModelObject.cpp', u'Source/WebCore/rendering/svg/RenderSVGResourceContainer.cpp', u'Source/WebCore/rendering/svg/RenderSVGTextPath.cpp', u'Source/WebCore/rendering/svg/SVGResources.cpp', u'Source/WebCore/rendering/svg/SVGResourcesCache.cpp', u'Source/WebCore/style/StyleResolveTree.cpp', u'Source/WebCore/svg/SVGAElement.cpp', u'Source/WebCore/svg/SVGAltGlyphElement.cpp', u'Source/WebCore/svg/SVGCursorElement.cpp', u'Source/WebCore/svg/SVGElement.cpp', u'Source/WebCore/svg/SVGElementInstance.cpp', u'Source/WebCore/svg/SVGElementRareData.h', u'Source/WebCore/svg/SVGFEConvolveMatrixElement.cpp', u'Source/WebCore/svg/SVGFEImageElement.cpp', u'Source/WebCore/svg/SVGFitToViewBox.h', u'Source/WebCore/svg/SVGFontFaceElement.cpp', u'Source/WebCore/svg/SVGFontFaceUriElement.cpp', u'Source/WebCore/svg/SVGGlyphRefElement.cpp', u'Source/WebCore/svg/SVGImageElement.cpp', u'Source/WebCore/svg/SVGImageLoader.cpp', u'Source/WebCore/svg/SVGLengthContext.cpp', u'Source/WebCore/svg/SVGLinearGradientElement.cpp', u'Source/WebCore/svg/SVGLocatable.cpp', u'Source/WebCore/svg/SVGMPathElement.cpp', u'Source/WebCore/svg/SVGPathElement.cpp', u'Source/WebCore/svg/SVGPatternElement.cpp', u'Source/WebCore/svg/SVGPolyElement.cpp', u'Source/WebCore/svg/SVGRadialGradientElement.cpp', u'Source/WebCore/svg/SVGSVGElement.cpp', u'Source/WebCore/svg/SVGScriptElement.cpp', u'Source/WebCore/svg/SVGStyleElement.cpp', u'Source/WebCore/svg/SVGStyleElement.h', u'Source/WebCore/svg/SVGTRefElement.cpp', u'Source/WebCore/svg/SVGTextContentElement.cpp', u'Source/WebCore/svg/SVGTextPathElement.cpp', u'Source/WebCore/svg/SVGTitleElement.cpp', u'Source/WebCore/svg/SVGUseElement.cpp', u'Source/WebCore/svg/SVGViewSpec.cpp', u'Source/WebCore/svg/SVGZoomAndPan.h', u'Source/WebCore/svg/animation/SVGSMILElement.cpp', u'Source/WebCore/svg/graphics/SVGImage.cpp', u'Source/WebCore/testing/Internals.cpp', u'Source/WebCore/xml/XMLSerializer.cpp', u'Source/WebCore/xml/XPathExpression.cpp', u'Source/WebCore/xml/XPathNodeSet.cpp', u'Source/WebCore/xml/XPathStep.cpp', u'Source/WebCore/xml/XSLStyleSheetLibxslt.cpp', u'Source/WebCore/xml/XSLTProcessor.cpp', u'Source/WebCore/xml/XSLTProcessorLibxslt.cpp', u'Source/WebCore/xml/parser/XMLDocumentParser.cpp', u'Source/WebCore/xml/parser/XMLDocumentParserLibxml2.cpp', u'Source/WebKit/efl/WebCoreSupport/EditorClientEfl.cpp', u'Source/WebKit/efl/ewk/ewk_frame.cpp', u'Source/WebKit/gtk/WebCoreSupport/ChromeClientGtk.cpp', u'Source/WebKit/gtk/WebCoreSupport/EditorClientGtk.cpp', u'Source/WebKit/mac/Plugins/WebBaseNetscapePluginView.mm', u'Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm', u'Source/WebKit/mac/WebCoreSupport/WebKitFullScreenListener.mm', u'Source/WebKit/mac/WebView/WebFrame.mm', u'Source/WebKit/mac/WebView/WebFullScreenController.mm', u'Source/WebKit/mac/WebView/WebHTMLRepresentation.mm', u'Source/WebKit/mac/WebView/WebHTMLView.mm', u'Source/WebKit/mac/WebView/WebPDFView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/win/WebElementPropertyBag.cpp', u'Source/WebKit/win/WebView.cpp', u'Source/WebKit/wince/WebCoreSupport/EditorClientWinCE.cpp', u'Source/WebKit2/Shared/WebHitTestResult.cpp', u'Source/WebKit2/WebProcess/FullScreen/WebFullScreenManager.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/API/mac/WKDOMNode.mm', u'Source/WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp', u'Source/WebKit2/WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm', u'Source/WebKit2/WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm', u'Source/WebKit2/WebProcess/Plugins/PluginView.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/WebEditorClient.cpp', u'Source/WebKit2/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp', u'Source/WebKit2/WebProcess/WebPage/FindController.cpp', u'Source/WebKit2/WebProcess/WebPage/WebFrame.cpp', u'Source/WebKit2/WebProcess/WebPage/WebPage.cpp', u'Source/WebKit2/WebProcess/WebPage/mac/WebPageMac.mm']" exit_code: 1
Source/WebKit/win/WebElementPropertyBag.cpp:130:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/dom/Element.cpp:715:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/dom/Element.cpp:740:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/dom/Node.cpp:1162:  Declaration has space between type name and * in Document *doc  [whitespace/declaration] [3]
Source/WebCore/dom/MouseEvent.cpp:242:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Source/WebCore/page/EventHandler.cpp:570:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/page/EventHandler.cpp:4160:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 7 in 317 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Early Warning System Bot 2013-08-29 15:26:34 PDT

Comment on attachment 210036 [details]
EWS experiment 1

Attachment 210036 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1606017

Comment 4 Early Warning System Bot 2013-08-29 15:26:51 PDT

Comment on attachment 210036 [details]
EWS experiment 1

Attachment 210036 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1626718

Comment 5 Andreas Kling 2013-08-29 15:35:56 PDT

Created attachment 210039 [details]
EWS experiment 2

Comment 6 Early Warning System Bot 2013-08-29 15:59:17 PDT

Comment on attachment 210039 [details]
EWS experiment 2

Attachment 210039 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1625702

Comment 7 Early Warning System Bot 2013-08-29 16:00:28 PDT

Comment on attachment 210039 [details]
EWS experiment 2

Attachment 210039 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1626724

Comment 8 Andreas Kling 2013-08-29 16:03:56 PDT

Created attachment 210041 [details]
EWS experiment 3

Comment 9 Early Warning System Bot 2013-08-29 16:22:33 PDT

Comment on attachment 210041 [details]
EWS experiment 3

Attachment 210041 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1638311

Comment 10 EFL EWS Bot 2013-08-29 16:24:25 PDT

Comment on attachment 210041 [details]
EWS experiment 3

Attachment 210041 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1624780

Comment 11 Early Warning System Bot 2013-08-29 16:28:57 PDT

Comment on attachment 210041 [details]
EWS experiment 3

Attachment 210041 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1644097

Comment 12 Andreas Kling 2013-08-29 16:48:04 PDT

Created attachment 210046 [details]
EWS experiment 4

Comment 13 Andreas Kling 2013-08-29 17:14:02 PDT

Created attachment 210052 [details]
EWS experiment 5

Comment 14 Andreas Kling 2013-08-29 17:28:22 PDT

Created attachment 210054 [details]
EWS experiment 6

Comment 15 Andreas Kling 2013-08-29 19:19:10 PDT

Created attachment 210057 [details]
EWS experiment 7

Comment 16 EFL EWS Bot 2013-08-29 19:48:19 PDT

Comment on attachment 210057 [details]
EWS experiment 7

Attachment 210057 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1647042

Comment 17 Andreas Kling 2013-08-29 19:51:27 PDT

Created attachment 210059 [details]
EWS experiment 8

Comment 18 EFL EWS Bot 2013-08-29 20:40:06 PDT

Comment on attachment 210059 [details]
EWS experiment 8

Attachment 210059 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1644156

Comment 19 Andreas Kling 2013-08-29 20:53:06 PDT

Created attachment 210063 [details]
EWS experiment 9

Comment 20 Andreas Kling 2013-08-29 21:10:47 PDT

Created attachment 210064 [details]
EWS experiment 10

Comment 21 Andreas Kling 2013-08-29 21:11:31 PDT

Created attachment 210065 [details]
EWS experiment 10

Comment 22 EFL EWS Bot 2013-08-29 21:43:34 PDT

Comment on attachment 210065 [details]
EWS experiment 10

Attachment 210065 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1627805

Comment 23 Andreas Kling 2013-08-29 22:10:05 PDT

Created attachment 210066 [details]
EWS experiment 11

Comment 24 EFL EWS Bot 2013-08-29 22:22:00 PDT

Comment on attachment 210066 [details]
EWS experiment 11

Attachment 210066 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1623825

Comment 25 kov's GTK+ EWS bot 2013-08-29 22:43:19 PDT

Comment on attachment 210066 [details]
EWS experiment 11

Attachment 210066 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1627822

Comment 26 EFL EWS Bot 2013-08-29 22:54:42 PDT

Comment on attachment 210066 [details]
EWS experiment 11

Attachment 210066 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1618834

Comment 27 Andreas Kling 2013-08-30 05:38:15 PDT

Created attachment 210092 [details]
EWS experiment 12

Comment 28 Andreas Kling 2013-08-30 05:56:23 PDT

Created attachment 210094 [details]
EWS experiment 13

Comment 29 Andreas Kling 2013-08-30 07:12:13 PDT

Created attachment 210105 [details]
Patch

Comment 30 Antti Koivisto 2013-08-30 07:17:41 PDT

Comment on attachment 210105 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210105&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:3820
>  #if PLATFORM(WIN) && USE(AVFOUNDATION)
>  GraphicsDeviceAdapter* HTMLMediaElement::mediaPlayerGraphicsDeviceAdapter(const MediaPlayer*) const
>  {
> -    if (!document() || !document()->page())
> +    if (!document() || !document().page())

That is not going to compile.

Comment 31 Andreas Kling 2013-08-30 07:29:53 PDT

Committed r154877: <http://trac.webkit.org/changeset/154877>