Bug 120558 - Don't do document style recalc unless there's a RenderView.
Summary: Don't do document style recalc unless there's a RenderView.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-31 06:10 PDT by Andreas Kling
Modified: 2013-08-31 07:07 PDT (History)
3 users (show)

See Also:

Attachments
Patch (8.50 KB, patch)
2013-08-31 06:18 PDT, Andreas Kling 		koivisto: review-
Details | Formatted Diff | Diff
Patch 2 (8.50 KB, patch)
2013-08-31 06:26 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
P4L (8.59 KB, patch)
2013-08-31 06:36 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-31 06:10:18 PDT 
Don't do document style recalc unless there's a RenderView.
Comment 1 Andreas Kling 2013-08-31 06:18:58 PDT 
Created attachment 210186 [details]
Patch
Comment 2 Antti Koivisto 2013-08-31 06:21:44 PDT 
Comment on attachment 210186 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210186&action=review

Looks generally good.

> Source/WebCore/dom/Document.cpp:-1738
> -    ASSERT(!view() || !view()->isPainting());

Please don't remove the painting assert. It is valuable!
Comment 3 Andreas Kling 2013-08-31 06:26:48 PDT 
Created attachment 210188 [details]
Patch 2
Comment 4 Andreas Kling 2013-08-31 06:36:01 PDT 
Created attachment 210189 [details]
P4L
Comment 5 WebKit Commit Bot 2013-08-31 07:07:18 PDT 
Comment on attachment 210189 [details]
P4L

Clearing flags on attachment: 210189

Committed r154927: <http://trac.webkit.org/changeset/154927>
Comment 6 WebKit Commit Bot 2013-08-31 07:07:20 PDT 
All reviewed patches have been landed.  Closing bug.