Bug 120562 - InlineBox::renderer() and pals should return references.
Summary: InlineBox::renderer() and pals should return references.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-31 09:50 PDT by Andreas Kling
Modified: 2013-08-31 11:33 PDT (History)
5 users (show)

See Also:

Attachments
Patch? (221.72 KB, patch)
2013-08-31 09:51 PDT, Andreas Kling 		eflews.bot: commit-queue-
Details | Formatted Diff | Diff
Patch! (222.21 KB, patch)
2013-08-31 10:30 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-31 09:50:45 PDT 
InlineBox::renderer() and pals should return references.
Comment 1 Andreas Kling 2013-08-31 09:51:15 PDT 
Created attachment 210195 [details]
Patch?
Comment 2 WebKit Commit Bot 2013-08-31 09:53:39 PDT 
Attachment 210195 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/editing/RenderedPosition.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/VisiblePosition.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/rendering/EllipsisBox.cpp', u'Source/WebCore/rendering/EllipsisBox.h', u'Source/WebCore/rendering/InlineBox.cpp', u'Source/WebCore/rendering/InlineBox.h', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RootInlineBox.cpp', u'Source/WebCore/rendering/RootInlineBox.h', u'Source/WebCore/rendering/TrailingFloatsRootInlineBox.h', u'Source/WebCore/rendering/svg/RenderSVGInline.cpp', u'Source/WebCore/rendering/svg/RenderSVGInlineText.cpp', u'Source/WebCore/rendering/svg/RenderSVGInlineText.h', u'Source/WebCore/rendering/svg/RenderSVGText.cpp', u'Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp', u'Source/WebCore/rendering/svg/SVGInlineFlowBox.h', u'Source/WebCore/rendering/svg/SVGInlineTextBox.cpp', u'Source/WebCore/rendering/svg/SVGInlineTextBox.h', u'Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp', u'Source/WebCore/rendering/svg/SVGRootInlineBox.cpp', u'Source/WebCore/rendering/svg/SVGRootInlineBox.h', u'Source/WebCore/rendering/svg/SVGTextChunkBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp', u'Source/WebCore/rendering/svg/SVGTextQuery.cpp']" exit_code: 1
Source/WebCore/rendering/InlineFlowBox.cpp:170:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/InlineFlowBox.cpp:171:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/InlineTextBox.cpp:512:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/InlineBox.cpp:355:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 4 in 42 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 EFL EWS Bot 2013-08-31 09:59:58 PDT 
Comment on attachment 210195 [details]
Patch?

Attachment 210195 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1661364
Comment 4 EFL EWS Bot 2013-08-31 10:02:49 PDT 
Comment on attachment 210195 [details]
Patch?

Attachment 210195 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1603350
Comment 5 kov's GTK+ EWS bot 2013-08-31 10:16:56 PDT 
Comment on attachment 210195 [details]
Patch?

Attachment 210195 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1659330
Comment 6 Andreas Kling 2013-08-31 10:30:41 PDT 
Created attachment 210196 [details]
Patch!
Comment 7 WebKit Commit Bot 2013-08-31 10:33:04 PDT 
Attachment 210196 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/dom/Position.cpp', u'Source/WebCore/editing/RenderedPosition.cpp', u'Source/WebCore/editing/TextIterator.cpp', u'Source/WebCore/editing/VisiblePosition.cpp', u'Source/WebCore/editing/VisibleUnits.cpp', u'Source/WebCore/rendering/EllipsisBox.cpp', u'Source/WebCore/rendering/EllipsisBox.h', u'Source/WebCore/rendering/InlineBox.cpp', u'Source/WebCore/rendering/InlineBox.h', u'Source/WebCore/rendering/InlineFlowBox.cpp', u'Source/WebCore/rendering/InlineFlowBox.h', u'Source/WebCore/rendering/InlineTextBox.cpp', u'Source/WebCore/rendering/InlineTextBox.h', u'Source/WebCore/rendering/RenderBlock.cpp', u'Source/WebCore/rendering/RenderBlock.h', u'Source/WebCore/rendering/RenderBlockLineLayout.cpp', u'Source/WebCore/rendering/RenderBox.cpp', u'Source/WebCore/rendering/RenderBox.h', u'Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp', u'Source/WebCore/rendering/RenderInline.cpp', u'Source/WebCore/rendering/RenderInline.h', u'Source/WebCore/rendering/RenderListMarker.cpp', u'Source/WebCore/rendering/RenderReplaced.cpp', u'Source/WebCore/rendering/RenderText.cpp', u'Source/WebCore/rendering/RootInlineBox.cpp', u'Source/WebCore/rendering/RootInlineBox.h', u'Source/WebCore/rendering/TrailingFloatsRootInlineBox.h', u'Source/WebCore/rendering/svg/RenderSVGInline.cpp', u'Source/WebCore/rendering/svg/RenderSVGInlineText.cpp', u'Source/WebCore/rendering/svg/RenderSVGInlineText.h', u'Source/WebCore/rendering/svg/RenderSVGText.cpp', u'Source/WebCore/rendering/svg/SVGInlineFlowBox.cpp', u'Source/WebCore/rendering/svg/SVGInlineFlowBox.h', u'Source/WebCore/rendering/svg/SVGInlineTextBox.cpp', u'Source/WebCore/rendering/svg/SVGInlineTextBox.h', u'Source/WebCore/rendering/svg/SVGRenderTreeAsText.cpp', u'Source/WebCore/rendering/svg/SVGRootInlineBox.cpp', u'Source/WebCore/rendering/svg/SVGRootInlineBox.h', u'Source/WebCore/rendering/svg/SVGTextChunkBuilder.cpp', u'Source/WebCore/rendering/svg/SVGTextLayoutEngine.cpp', u'Source/WebCore/rendering/svg/SVGTextQuery.cpp']" exit_code: 1
Source/WebCore/rendering/InlineFlowBox.cpp:170:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/InlineFlowBox.cpp:171:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Source/WebCore/rendering/InlineTextBox.cpp:512:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
Source/WebCore/rendering/InlineBox.cpp:355:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 4 in 42 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 WebKit Commit Bot 2013-08-31 11:33:23 PDT 
Comment on attachment 210196 [details]
Patch!

Clearing flags on attachment: 210196

Committed r154931: <http://trac.webkit.org/changeset/154931>
Comment 9 WebKit Commit Bot 2013-08-31 11:33:25 PDT 
All reviewed patches have been landed.  Closing bug.