Bug 120684 - Simplify subtree relayout scheduling a bit.
Summary: Simplify subtree relayout scheduling a bit.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on: 121524
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-04 08:36 PDT by Andreas Kling
Modified: 2013-09-17 15:48 PDT (History)
6 users (show)

See Also:

Attachments
Patch idea. (6.30 KB, patch)
2013-09-04 08:37 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
Patch for landing... (6.34 KB, patch)
2013-09-04 09:13 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-04 08:36:18 PDT 
Simplify subtree relayout scheduling a bit.
Comment 1 Andreas Kling 2013-09-04 08:37:00 PDT 
Created attachment 210462 [details]
Patch idea.
Comment 2 Antti Koivisto 2013-09-04 09:08:18 PDT 
Comment on attachment 210462 [details]
Patch idea.

View in context: https://bugs.webkit.org/attachment.cgi?id=210462&action=review

> Source/WebCore/page/FrameView.cpp:2445
> +    if (m_layoutRoot == &relayoutRoot)
> +        return;

The argument could use a better name. newLayoutRoot?

> Source/WebCore/page/FrameView.cpp:2466
> +        InspectorInstrumentation::didInvalidateLayout(&frame());

There is some repetition with this. I wonder if splitting this up to two functions would look nicer. The inner one would return bool if it actually did invalidate layout for example.
Comment 3 Andreas Kling 2013-09-04 09:13:40 PDT 
Created attachment 210467 [details]
Patch for landing...
Comment 4 WebKit Commit Bot 2013-09-04 09:40:36 PDT 
Comment on attachment 210467 [details]
Patch for landing...

Clearing flags on attachment: 210467

Committed r155046: <http://trac.webkit.org/changeset/155046>
Comment 5 WebKit Commit Bot 2013-09-04 09:40:38 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2013-09-04 11:07:48 PDT 
This change made many (maybe all?) SVG tests crash with an assertion in debug builds. See <rdar://problem/14908967> for an Apple internal bug.
Comment 7 Andreas Kling 2013-09-04 11:32:41 PDT 
(In reply to comment #6)
> This change made many (maybe all?) SVG tests crash with an assertion in debug builds. See <rdar://problem/14908967> for an Apple internal bug.

Fix here: bug 120689
Comment 8 Alexey Proskuryakov 2013-09-17 15:48:53 PDT 
More fallback from this change: bug 121524.