Bug 121051 - Hide node() below RenderSVGModelObject, use element() instead.
Summary: Hide node() below RenderSVGModelObject, use element() instead.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-09 15:06 PDT by Andreas Kling
Modified: 2013-09-09 16:01 PDT (History)
10 users (show)

See Also:


Attachments
Patch (43.52 KB, patch)
2013-09-09 15:15 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-09 15:06:24 PDT
RenderSVGModelObject and subclasses only ever have SVGElement as their node(). Let's tighten this up.
Comment 1 Andreas Kling 2013-09-09 15:15:55 PDT
Created attachment 211102 [details]
Patch
Comment 2 Antti Koivisto 2013-09-09 15:29:52 PDT
Comment on attachment 211102 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211102&action=review

> Source/WebCore/rendering/svg/RenderSVGModelObject.h:72
> +    SVGElement* element() const { return toSVGElement(RenderObject::node()); }

Going with svgElement() might make sense to clarify tighter typing.
Comment 3 WebKit Commit Bot 2013-09-09 16:01:38 PDT
Comment on attachment 211102 [details]
Patch

Clearing flags on attachment: 211102

Committed r155398: <http://trac.webkit.org/changeset/155398>
Comment 4 WebKit Commit Bot 2013-09-09 16:01:41 PDT
All reviewed patches have been landed.  Closing bug.