Bug 121073 - HTMLTextAreaElement no longer needs custom style resolve callbacks.
Summary: HTMLTextAreaElement no longer needs custom style resolve callbacks.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on: 121058
Blocks:
  Show dependency tree / graph
 
Reported: 2013-09-09 20:31 PDT by Andreas Kling
Modified: 2013-09-09 23:10 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2013-09-09 20:32 PDT, Andreas Kling 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-09 20:31:53 PDT 
HTMLTextAreaElement no longer needs custom style resolve callbacks.
Comment 1 Andreas Kling 2013-09-09 20:32:26 PDT 
Created attachment 211147 [details]
Patch
Comment 2 Ryosuke Niwa 2013-09-09 21:07:49 PDT 
Comment on attachment 211147 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=211147&action=review

> Source/WebCore/ChangeLog:9
> +        Now that it doesn't override didAttachRenderer() anymore, there's no need
> +        to fire callbacks for textarea elements during style resolve.

Please refer to http://trac.webkit.org/changeset/155408.
Comment 3 Andreas Kling 2013-09-09 23:06:47 PDT 
Committed r155419: <http://trac.webkit.org/changeset/155419>
Comment 4 Andreas Kling 2013-09-09 23:10:27 PDT 
Manual commits are hard.
Accident cleanup: <http://trac.webkit.org/changeset/155421>