Bug 121146 - Rename BackForwardListImpl => BackForwardList.
Summary: Rename BackForwardListImpl => BackForwardList.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-09-11 01:11 PDT by Andreas Kling
Modified: 2013-09-11 01:37 PDT (History)
5 users (show)

See Also:

Attachments
Patch (39.96 KB, patch)
2013-09-11 01:15 PDT, Andreas Kling 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-09-11 01:11:33 PDT 
Another old FIXME.
Comment 1 Andreas Kling 2013-09-11 01:15:02 PDT 
Created attachment 211287 [details]
Patch
Comment 2 WebKit Commit Bot 2013-09-11 01:16:56 PDT 
Attachment 211287 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/WebCore.exp.in', u'Source/WebCore/history/BackForwardController.cpp', u'Source/WebCore/history/BackForwardListImpl.cpp', u'Source/WebCore/history/BackForwardListImpl.h', u'Source/WebKit/efl/ewk/ewk_history.cpp', u'Source/WebKit/efl/ewk/ewk_history_private.h', u'Source/WebKit/efl/ewk/ewk_view.cpp', u'Source/WebKit/gtk/webkit/webkitwebbackforwardlist.cpp', u'Source/WebKit/gtk/webkit/webkitwebbackforwardlistprivate.h', u'Source/WebKit/gtk/webkit/webkitwebview.cpp', u'Source/WebKit/mac/History/WebBackForwardList.mm', u'Source/WebKit/mac/History/WebBackForwardListInternal.h', u'Source/WebKit/mac/WebView/WebFrameView.mm', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/qt/Api/qwebhistory.cpp', u'Source/WebKit/qt/Api/qwebhistory_p.h', u'Source/WebKit/qt/WebCoreSupport/QWebPageAdapter.cpp', u'Source/WebKit/win/WebBackForwardList.cpp', u'Source/WebKit/win/WebBackForwardList.h', u'Source/WebKit/win/WebView.cpp']" exit_code: 1
Source/WebKit/win/WebBackForwardList.h:37:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Source/WebCore/history/BackForwardListImpl.h:28:  #ifndef header guard has wrong style, please use: BackForwardListImpl_h  [build/header_guard] [5]
Source/WebKit/qt/Api/qwebhistory.cpp:260:  Should have a space between // and comment  [whitespace/comments] [4]
Source/WebKit/mac/History/WebBackForwardListInternal.h:33:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 4 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-09-11 01:37:18 PDT 
Committed r155510: <http://trac.webkit.org/changeset/155510>